Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change admission-tracer pull policy and kas shutdown config #1454

Closed
wants to merge 6 commits into from

Conversation

pcrentsil
Copy link
Contributor

Deployment Yaml updated Image Pull Policy for Hypershift.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Added shutdown-send-retry-after & Updated shutdown-delay-duration
Added shutdown-send-retry-after & Updated shutdown-delay-duration
@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit c32286d
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/62a20ac1e8fb320008ab38e3
😎 Deploy Preview https://deploy-preview-1454--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pcrentsil
To complete the pull request process, please assign sjenning after the PR has been reviewed.
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label tide/merge-method-squash

Please provide a proper PR description that includes information as to why you want to do this change

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 9, 2022
@enxebre
Copy link
Member

enxebre commented Jun 15, 2022

@pcrentsil could you squash commits into a single one with an imperative message e.g "Change admission-tracer pull policy and kas shutdown config"

@enxebre
Copy link
Member

enxebre commented Jun 15, 2022

/retitle Change admission-tracer pull policy and kas shutdown config

@openshift-ci openshift-ci bot changed the title Hypershift Image Pull Policy Updated Change admission-tracer pull policy and kas shutdown config Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2022

@pcrentsil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 04a6329 link true /test e2e-aws
ci/prow/e2e-kubevirt-gcp-ovn 04a6329 link false /test e2e-kubevirt-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hasueki
Copy link
Contributor

hasueki commented Jun 23, 2022

Superseded by #1473

@hasueki
Copy link
Contributor

hasueki commented Jun 23, 2022

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@hasueki: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcrentsil pcrentsil closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants