-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ImagePullPolicyIfNotPresent for HO #1473
Conversation
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -17,7 +17,7 @@ spec: | |||
- command: | |||
- /usr/bin/admission-tracer | |||
image: quay.io/sjenning/admission-tracer:latest | |||
imagePullPolicy: Always | |||
imagePullPolicy: IfNotPresent | |||
name: admission-tracer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjenning Do we want to keep this as Always
? I see that the image references the latest
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dev debugging tool, I think Always makes more sense
@@ -191,7 +191,8 @@ func generateConfig(p KubeAPIServerConfigParams, version semver.Version) *kcpv1. | |||
args.Set("service-account-lookup", "true") | |||
args.Set("service-account-signing-key-file", cpath(kasVolumeServiceAccountKey().Name, pki.ServiceSignerPrivateKey)) | |||
args.Set("service-node-port-range", p.NodePortRange) | |||
args.Set("shutdown-delay-duration", "10s") | |||
args.Set("shutdown-delay-duration", "70s") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this is related to ImagePullPolicy. Please read our contributing guide: https://hypershift-docs.netlify.app/contribute/
/hold
/label tide/merge-method/squash |
@alvaroaleman: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label tide/merge-method-squash |
28e138a
to
9171e7c
Compare
9171e7c
to
43d084b
Compare
@alvaroaleman comments were updated, commits squashed please take a look. Thank you, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retitle Use ImagePullPolicyIfNotPresent for HO
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, pcrentsil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pcrentsil: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherry-pick release-4.9 |
@hasueki: new pull request created: #1482 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.10 |
@hasueki: new pull request created: #1483 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Do not always pull Hypershift images
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist