Add PowerVS Ingress Operator Changes #1458
Conversation
|
/cc @mkumatag |
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| // This field is immutable. Once set, It can't be changed. | ||
| // | ||
| // +immutable | ||
| CISInstanceCRN string `json:"cisInstanceCRN"` |
There was a problem hiding this comment.
can we do any allowed input validation here? can we add an example to the // doc?
There was a problem hiding this comment.
Added a validation here. But this will be generated by the Infra creation process by getting the UUID of the base-domain passed. We already talked about CIS base domain in prerequisite section of PowerVS how-to guide.
| // credentials for ingress operator to get authenticated with ibm cloud. | ||
| // | ||
| // +immutable | ||
| IngressOperatorCloudCreds corev1.LocalObjectReference `json:"ingressOperatorCloudCreds"` |
There was a problem hiding this comment.
Updated the PR description, please check.
|
I can see the "what" this code doing, but could you please elaborate in the PR and commit desc the "why" these changes are needed? e.g this introduces a IngressOperatorCloudCreds because... (what's solving not possible without it?) |
dharaneeshvrd
force-pushed
the
powervs-ingress
branch
from
8d9ad65
to
f26f061
Compare
|
@enxebre Updated the PR description, please have a look. |
|
/lgtm |
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
added
lgtm
|
@dharaneeshvrd looks like you need to rebase |
dharaneeshvrd
force-pushed
the
powervs-ingress
branch
from
f26f061
to
a47abed
Compare
openshift-ci
bot
removed
the
needs-rebase
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, dharaneeshvrd, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dharaneeshvrd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Added changes for ingress operator https://github.com/openshift/cloud-ingress-operator respect to powervs cloud.
Where secret named
cloud-credentialsand CIS CRN, PowerVS Region and Zone details are required.Introduced IngressOperatorCloudCreds in hostedcluster_types.go to create this
cloud-credentialssecret. Added this as a new secret, so that when we are handling granular permissions in future, we can add appropriate permissions with respect to ingress operator to this secret alone.Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist