-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PowerVS Ingress Operator Changes #1458
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -590,6 +590,13 @@ type PowerVSPlatformSpec struct { | |
// +immutable | ||
AccountID string `json:"accountID"` | ||
|
||
// CISInstanceCRN is the IBMCloud CIS Service Instance's Cloud Resource Name | ||
// This field is immutable. Once set, It can't be changed. | ||
// | ||
// +kubebuilder:validation:Pattern=`^crn:` | ||
// +immutable | ||
CISInstanceCRN string `json:"cisInstanceCRN"` | ||
|
||
// ResourceGroup is the IBMCloud Resource Group in which the cluster resides. | ||
// This field is immutable. Once set, It can't be changed. | ||
// | ||
|
@@ -663,6 +670,12 @@ type PowerVSPlatformSpec struct { | |
// | ||
// +immutable | ||
ControlPlaneOperatorCreds corev1.LocalObjectReference `json:"controlPlaneOperatorCreds"` | ||
|
||
// IngressOperatorCloudCreds is a reference to a secret containing ibm cloud | ||
// credentials for ingress operator to get authenticated with ibm cloud. | ||
// | ||
// +immutable | ||
IngressOperatorCloudCreds corev1.LocalObjectReference `json:"ingressOperatorCloudCreds"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated the PR description, please check. |
||
} | ||
|
||
// PowerVSVPC specifies IBM Cloud PowerVS LoadBalancer configuration for the control | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do any allowed input validation here? can we add an example to the // doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a validation here. But this will be generated by the Infra creation process by getting the UUID of the base-domain passed. We already talked about CIS base domain in prerequisite section of PowerVS how-to guide.