.travis.yml: Prune moved-to-Prow tf-lint, etc.

[wking]

These have moved into Prow presubmit jobs:

• Terraform lint: openshift/release@82e00346 (Prow: Add terraform lintern to openshift/installer release#1124).
• YAML lint: openshift/release@457be2cd (Added prow yaml-lint job description for installer repo release#1138).
• ShellCheck: openshift/release@e12a7a06 (Prow: Add shell check to openshift/installer release#1131).
• Terraform format: openshift/release@f67e06e4 (openshift installer: add terraform fmt release#1152).
• Building the tarball: openshift/release@42a5a0d0 (add openshift/installer 'bazel build tarball' test to prow release#1178).

[wking]

The build-tarball error was:

+ bazel --output_base=/tmp build tarball
Error: $USER is not set, and unable to look up name of current user: (error: 0): Success

Maybe the Prow config for that job is broken? Looks like it just landed four hours ago.

[wking]

/hold

I've pushed a WIP commit to set the USER. If that fixes the Bazel failure, I'll update the Prow config appropriately. Until then, we don't want to merge this PR.

[wking]

/hold cancel

I've dropped the WIP testing commit now that I've spun off the tarball fixes into and openshift/release#1185 and #125.

[wking]

I've pushed e4740aa -> 1765e93 to also drop go-vet, now that openshift/release@71afdcca (openshift/release#1181) has landed.

[wking]

/retest

[wking]

All green :).

/assign @abhinavdahiya

The remaining Go lint Travis job is being addressed by #118 and openshift/release#1177. The Go unit test job has already been partially addressed with #97, although I'm not aware of an analogous release PR for gotest.sh. But I don't think we need to wait on those before landing this.

[abhinavdahiya]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sallyom]

@wking the go unit test is also moved to prow already, it's running within ci-operator here: https://github.com/openshift/release/blob/master/ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml#L3 and with this master.json: https://github.com/openshift/release/blob/master/ci-operator/config/openshift/installer/master.json#L44
(installer/hack/gotest.sh was merged in before we realized the ci/prow/unit was already configured to run go test.. we can remove gotest.sh, it is not required for use in prow. I can open a PR to remove hack/gotest.sh or you can remove it with this PR, as well as the task in the .travis.yaml)

[wking]

The e2e-aws errors were:

Error: Error refreshing state: 2 error(s) occurred:

* module.assets_base.module.bootkube.data.ignition_file.bootkube_sh: 1 error(s) occurred:

* module.assets_base.module.bootkube.data.ignition_file.bootkube_sh: data.ignition_file.bootkube_sh: unexpected EOF
* module.assets_base.data.ignition_config.etcd: 3 error(s) occurred:

* module.assets_base.data.ignition_config.etcd[2]: data.ignition_config.etcd.2: unexpected EOF
* module.assets_base.data.ignition_config.etcd[1]: data.ignition_config.etcd.1: unexpected EOF
* module.assets_base.data.ignition_config.etcd[0]: data.ignition_config.etcd.0: unexpected EOF

Not sure what's going on there.

/retest

[wking]

... the go unit test is also moved to prow already, it's running within ci-operator here...

Ah, thanks for the pointers. I've filed #135 to drop the script.