Prow: Add terraform lintern to openshift/installer #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/S
alejovicu
changed the title
|
/assign @bbguimaraes |
cluster/ci/config/prow/config.yaml
Outdated
| @@ -3174,6 +3174,20 @@ presubmits: | |||
| - --template=/usr/local/e2e-aws | |||
| - --target=e2e-aws | |||
|
|
|||
| - name: terraform-lint | |||
| trigger: "(?m)^/tflint" | |||
| rerun_command: "/tflint" | |||
There was a problem hiding this comment.
Convention is to use /test <test-name>
cluster/ci/config/prow/config.yaml
Outdated
| - name: terraform-lint | ||
| trigger: "(?m)^/tflint" | ||
| rerun_command: "/tflint" | ||
| context: terraform-lint |
There was a problem hiding this comment.
Convention is to use ci/prow/<name>
|
/ok-to-test |
openshift-ci-robot
removed
the
needs-ok-to-test
|
@alejovicu, this needs a rebase (at least according to GitHub :p). |
cluster/ci/config/prow/config.yaml
Outdated
| @@ -3209,6 +3209,20 @@ presubmits: | |||
| - --template=/usr/local/e2e-aws | |||
| - --target=e2e-aws | |||
|
|
|||
| - name: terraform-lint | |||
There was a problem hiding this comment.
sorry, final nit -- this is usually ci-pull-$org-$repo-$name
|
Please do not merge until openshift/installer#109 is merged |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Ready for merge |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
@alejovicu: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 14, 2018
These have moved into Prow presubmit jobs: * Terraform lint: openshift/release@82e00346 (Prow: Add Terraform Lint to openshift/installer, 2018-08-06, openshift/release#1124). * YAML lint: openshift/release@457be2cd (Added prow yaml-lint job description for installer repo, 2018-08-02, openshift/release#1138). * ShellCheck: openshift/release@e12a7a06 (Prow: Add shellcheck to openshift/installer, 2018-08-08, openshift/release#1131). * Terraform format: openshift/release@f67e06e4 (openshift installer: add terraform fmt, 2018-08-04, openshift/release#1152). * Go vet: openshift/release@71afdcca (Added go-vet prow job, 2018-08-14, openshift/release#1181). * Building the tarball: openshift/release@42a5a0d0 (add openshift/installer 'bazel build tarball' test to prow, 2018-08-13, openshift/release#1178).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Terraform lintern to openshift/installer. (CORS-744)