-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG: Document changes since v0.3.0 #595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changelogs are awesome!
3a891bb
to
e15703e
Compare
I've pushed 3a891bb -> e15703e, rebasing around #594 and documenting that change. |
Rebased onto master and documenting #579 with e15703e -> d250485. |
/retest |
Rebased onto master with 06a891c -> e9ee174. Lots of commits since v0.3.0, so there were quite a few changes I judged too minor/internal to be worth a release-notes mention. But I'm happy to add things if folks feel like I missed something important (or remove things if folks feel like nobody will care about a given entry ;). It will be good to get back onto the release train. |
Through 024ef63 (Merge pull request openshift#715 from wking/drop-deprecated-commands, 2018-11-21).
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I addressed his points, and he's since /lgtm
ed tge PR
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Since we completely removed the old subcommands, I'd added entries to the "Added" and "Removed" sections while rebasing 220a5f7 (CHANGELOG: Document changes since v0.3.0, 2018-11-01, openshift#595). But I forgot to remove the entry from the "Changed" section when I did that. I'm removing it now. Also fix a broken indent for the bootstrap-kubelet entry.
Through 036c5ac (#593).
I've set the provisional v0.4.0 release date to Friday the 2nd.
I'm guessing a bit at docs for some of the pull requests I was less involved in. Review deeper than a quick skim is welcome :).