Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Document changes since v0.3.0 #595

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

wking
Copy link
Member

@wking wking commented Nov 1, 2018

Through 036c5ac (#593).

I've set the provisional v0.4.0 release date to Friday the 2nd.

I'm guessing a bit at docs for some of the pull requests I was less involved in. Review deeper than a quick skim is welcome :).

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2018
Copy link
Contributor

@crawford crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changelogs are awesome!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@wking wking force-pushed the version-0.4.0 branch 2 times, most recently from 3a891bb to e15703e Compare November 2, 2018 16:51
@wking
Copy link
Member Author

wking commented Nov 2, 2018

I've pushed 3a891bb -> e15703e, rebasing around #594 and documenting that change.

@wking
Copy link
Member Author

wking commented Nov 2, 2018

Rebased onto master and documenting #579 with e15703e -> d250485.

@wking
Copy link
Member Author

wking commented Nov 2, 2018

I've pushed d250485 -> 06a891c, rebasing around and documenting #549. Still in the merge queue: #547, #601, #604 (of those, #547 certainly needs a change-log entry).

@wking
Copy link
Member Author

wking commented Nov 3, 2018

/retest

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2018
@wking
Copy link
Member Author

wking commented Nov 21, 2018

Rebased onto master with 06a891c -> e9ee174. Lots of commits since v0.3.0, so there were quite a few changes I judged too minor/internal to be worth a release-notes mention. But I'm happy to add things if folks feel like I missed something important (or remove things if folks feel like nobody will care about a given entry ;). It will be good to get back onto the release train.

Through 024ef63 (Merge pull request openshift#715 from
wking/drop-deprecated-commands, 2018-11-21).
@wking
Copy link
Member Author

wking commented Nov 22, 2018

Rebased onto master (024ef63) with dc0f820 -> 220a5f7. This includes #715, so I think we're good to go. I've guessed at the 22nd (tomorrow) as a possible release date, but I can bump that back to Monday if folks don't expect to have time to review the most recent additions before then.

@crawford
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking wking dismissed crawford’s stale review November 22, 2018 05:43

I addressed his points, and he's since /lgtmed tge PR

@openshift-merge-robot openshift-merge-robot merged commit c620a9b into openshift:master Nov 22, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 220a5f7 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wking added a commit to wking/openshift-installer that referenced this pull request Nov 23, 2018
Since we completely removed the old subcommands, I'd added entries to
the "Added" and "Removed" sections while rebasing 220a5f7 (CHANGELOG:
Document changes since v0.3.0, 2018-11-01, openshift#595).  But I forgot to
remove the entry from the "Changed" section when I did that.  I'm
removing it now.

Also fix a broken indent for the bootstrap-kubelet entry.
@wking wking deleted the version-0.4.0 branch November 24, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants