Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/asset/machines/libvirt: allow empty machinepool #601

Merged
merged 1 commit into from
Nov 2, 2018
Merged

pkg/asset/machines/libvirt: allow empty machinepool #601

merged 1 commit into from
Nov 2, 2018

Conversation

abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Nov 2, 2018 •
edited
Loading

Empty machinepool is a valid for libvirt because we don't use it.

Fixes the error

FATAL Error executing openshift-install: non-Libvirt machine-pool: ""

introduced in #573
/cc @wking

@abhinavdahiya
pkg/asset/machines/libvirt: allow empty machinepool
63c2ee8 
Empty machinepool is a valid for libvirt because we don't use it.

Fixes the error
```console
FATAL Error executing openshift-install: non-Libvirt machine-pool: ""
``
introduced in openshift#573
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2018
@abhinavdahiya
Copy link
Contributor Author 

info: Using registry public hostname registry.svc.ci.openshift.org
error: unable to check your credentials - pass --skip-check to bypass this error: Get https://registry.svc.ci.openshift.org/v2/: net/http: TLS handshake timeout
2018/11/02 19:22:07 Container release in pod release-latest failed, exit code 1, reason Error

/retest

wking
wking approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor Author

/test e2e-aws

1 similar comment
@abhinavdahiya
Copy link
Contributor Author

/test e2e-aws

@wking wking mentioned this pull request Nov 2, 2018
Merged
@openshift-merge-robot openshift-merge-robot merged commit 07c2c4f into openshift:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhinavdahiya @openshift-ci-robot @wking @openshift-merge-robot