Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Java 17 instead of Java 8 #1708

Closed
wants to merge 1 commit into from
Closed

Installing Java 17 instead of Java 8 #1708

wants to merge 1 commit into from

Conversation

AlbertoPimpo
Copy link
Contributor

@AlbertoPimpo AlbertoPimpo commented Aug 16, 2023

Since Java 8 is no more compatible with Jenkins since version 2.361.1 (see jenkins docs), so there is no more reason to install it in the image.

Instead, since the same version (see jenkins docs), Jenkins supports Java 17, so it makes sense to install it in the image so that early adopters can already try it.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlbertoPimpo
Once this PR has been reviewed and has the lgtm label, please assign coreydaley for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

Hi @AlbertoPimpo. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley
Copy link
Member

We can add Java 17 probably, but we can not remove Java 8 yet. There are some users which may still use Java 8 in their jobs so we want it to continue to be available.

@AlbertoPimpo
Copy link
Contributor Author

AlbertoPimpo commented Aug 17, 2023

We can add Java 17 probably, but we can not remove Java 8 yet. There are some users which may still use Java 8 in their jobs so we want it to continue to be available.

I'm not sure how many people are going to use it. Consider that by default the execution of jobs in the built-in node is de facto disabled (configured with 0 executors) and in general is discouraged (see jenkins docs).

@coreydaley
Copy link
Member

I believe that in our images that is not disabled by default yet.

@AlbertoPimpo
Copy link
Contributor Author

I believe that in our images that is not disabled by default yet.

You're actually right. I checked and the built-in node is not disabled by default, it is used if it is the only node that you have.

So, the only case in which you could benefit having Java 8 is the case in which you don't have any external node or k8s integration and you need to run a specific job that can only run on Java 8. Given that, I think it is safe to drop it.
If you don't think so I will put it back in the PR.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2024
@coreydaley
Copy link
Member

/close

@openshift-ci openshift-ci bot closed this Jan 26, 2024
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

@coreydaley: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants