-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing Java 17 instead of Java 8 #1708
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AlbertoPimpo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @AlbertoPimpo. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We can add Java 17 probably, but we can not remove Java 8 yet. There are some users which may still use Java 8 in their jobs so we want it to continue to be available. |
I'm not sure how many people are going to use it. Consider that by default the execution of jobs in the built-in node is de facto disabled (configured with 0 executors) and in general is discouraged (see jenkins docs). |
I believe that in our images that is not disabled by default yet. |
You're actually right. I checked and the built-in node is not disabled by default, it is used if it is the only node that you have. So, the only case in which you could benefit having Java 8 is the case in which you don't have any external node or k8s integration and you need to run a specific job that can only run on Java 8. Given that, I think it is safe to drop it. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/close |
@coreydaley: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since Java 8 is no more compatible with Jenkins since version 2.361.1 (see jenkins docs), so there is no more reason to install it in the image.
Instead, since the same version (see jenkins docs), Jenkins supports Java 17, so it makes sense to install it in the image so that early adopters can already try it.