Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 17 #1758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Java 17 #1758

wants to merge 2 commits into from

Conversation

AlbertoPimpo
Copy link
Contributor

After the discussions in #1708, @coreydaley explained why java 8 is still needed in the image. With this MR, I added only v. 17 instead of also removing v. 8.

Copy link
Contributor

openshift-ci bot commented Jan 27, 2024

Hi @AlbertoPimpo. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2024
@coreydaley
Copy link
Member

/assign @divyansh42
Along with install Java 17, we probably need to start looking into having Java 17 (or maybe even 21?) be the default that runs Jenkins, as support for Java 11 ends this fall sometime I believe.

@coreydaley
Copy link
Member

@AlbertoPimpo I think that https://github.com/openshift/jenkins/blob/master/2/Dockerfile.rhel8#L68-L73 also needs to be updated with this pull request.

@AlbertoPimpo
Copy link
Contributor Author

AlbertoPimpo commented Feb 13, 2024

@AlbertoPimpo I think that https://github.com/openshift/jenkins/blob/master/2/Dockerfile.rhel8#L68-L73 also needs to be updated with this pull request.

@coreydaley Thanks for the hint, I modified the PR to make Java 17 the default runtime.

Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlbertoPimpo
Once this PR has been reviewed and has the lgtm label, please ask for approval from divyansh42. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coreydaley
Copy link
Member

So, we actually have a JIRA on our side to update to Java 21 in the near future, just an FYI.

@AlbertoPimpo
Copy link
Contributor Author

AlbertoPimpo commented Feb 22, 2024

So, we actually have a JIRA on our side to update to Java 21 in the near future, just an FYI.

@coreydaley would you prefer to change this PR to add java 21 instead?

@BeastHook
Copy link

Is it foreseeable when the Java17 version will be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants