[wip] On disk fake client #1729
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
deads2k
force-pushed
the
on-disk-fake-client
branch
2 times, most recently
from
87ae1d1
to
e1a3b51
Compare
deads2k
force-pushed
the
on-disk-fake-client
branch
from
e1a3b51
to
68ab19e
Compare
| @@ -123,6 +125,24 @@ func (mrt *manifestRoundTripper) RoundTrip(req *http.Request) (*http.Response, e | |||
| // TODO handle label and field selectors | |||
| returnBody, returnErr = mrt.list(requestInfo) | |||
|
|
|||
| case "watch": | |||
| // our watches do nothing. We keep the connection alive (I think), but nothing else. | |||
There was a problem hiding this comment.
Listing all file based resources at start up can be interpreted either like creating or updating all of these for the first time. The code should generate corresponding create, resp. update events here for all the listable items. So the registered even handlers can react. Does the current roundtrip watch implementation lead to generating the events?
Allow resource discovery from must-gather
|
@deads2k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
wire up a fake client using a must-gather style directory.
Needs more tests prior to merge.
My gosh, who made this format. We should clearly fix it...
/assign @ingvagabund