Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-6.0] Backport PR grafana/loki#14447 #375

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

periklis
Copy link

Backport kubebuilder layout refactoring from go/v3 to go/v4 to release-6.0.

/cc @xperimental @JoaoBraveCoding

@periklis periklis self-assigned this Oct 21, 2024
@periklis
Copy link
Author

/hold Until release 6.0.1 goes out.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
Copy link

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@periklis periklis force-pushed the backport-pr-14447-6.0 branch 2 times, most recently from c0993d1 to 0617d2e Compare October 22, 2024 10:55
@periklis periklis force-pushed the backport-pr-14447-6.0 branch from 0617d2e to 4cd7380 Compare October 23, 2024 18:26
@periklis
Copy link
Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2024
Copy link

openshift-ci bot commented Oct 23, 2024

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@periklis periklis merged commit 31d5bce into openshift:release-6.0 Oct 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant