Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(operator)!: Migrate project layout to kubebuilder go/v4 #14447

Merged
merged 9 commits into from
Oct 21, 2024
Merged

refactor(operator)!: Migrate project layout to kubebuilder go/v4 #14447

merged 9 commits into from
Oct 21, 2024

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Oct 10, 2024 •
edited
Loading

What this PR does / why we need it:
Upgrades the operator project layout from kubebuilder go/v3 to go/v4. This enables to use kustomize v5 and in turn re-instantiates manifest and go code scaffolding.

Which issue(s) this PR fixes:
Fixes #11419

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Oct 10, 2024
@periklis periklis force-pushed the operator-go-v4-layout branch from be888ea to 9a68a5b Compare October 11, 2024 13:57
@periklis periklis force-pushed the operator-go-v4-layout branch from 9a68a5b to 7feb4b3 Compare October 14, 2024 10:37
@periklis periklis marked this pull request as ready for review October 14, 2024 10:38
JoaoBraveCoding
JoaoBraveCoding reviewed Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm from my side, just one question

operator/config/overlays/community/manager_auth_proxy_patch.yaml Outdated Show resolved Hide resolved
xperimental
xperimental reviewed Oct 17, 2024
View reviewed changes
operator/Dockerfile Outdated Show resolved Hide resolved
operator/Dockerfile Outdated Show resolved Hide resolved
operator/Dockerfile.cross Outdated Show resolved Hide resolved
operator/go.mod Show resolved Hide resolved
operator/internal/controller/loki/lokistack_controller.go Show resolved Hide resolved
.../bundle/openshift/manifests/loki-operator-controller-manager-metrics-service_v1_service.yaml Outdated Show resolved Hide resolved
operator/config/crd/kustomization.yaml Outdated Show resolved Hide resolved
operator/config/overlays/community/kustomization.yaml Outdated Show resolved Hide resolved
operator/config/overlays/openshift/kustomization.yaml Show resolved Hide resolved
operator/config/scorecard/kustomization.yaml Show resolved Hide resolved
@JoaoBraveCoding
Copy link
Collaborator

WDYT of making the title of this PR a breaking change? The last one we did to try and advance the operator version wasn't done properly, the "!" should come after the component deps(operator)!: Migrate project layout to kubebuilder go/v4 like shown here and not feat!(operator): Update Loki operand to v3.2.0 like I suggested in #14331 🤦

@periklis periklis changed the title chore(operator): Migrate project layout to kubebuilder go/v4 deps(operator)!: Migrate project layout to kubebuilder go/v4 Oct 18, 2024
@periklis periklis changed the title deps(operator)!: Migrate project layout to kubebuilder go/v4 refactor(operator)!: Migrate project layout to kubebuilder go/v4 Oct 18, 2024
JoaoBraveCoding
JoaoBraveCoding approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from my side

@periklis periklis merged commit dbb3b6e into grafana:main Oct 21, 2024
68 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 21, 2024
Merged
periklis added a commit to periklis/loki that referenced this pull request Oct 21, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
fe3d7b5 
…fana#14447)
periklis added a commit to periklis/loki that referenced this pull request Oct 21, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
fc37109 
…fana#14447)
periklis added a commit to periklis/loki that referenced this pull request Oct 21, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
e16b335 
…fana#14447)
periklis added a commit to periklis/loki that referenced this pull request Oct 21, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
c0993d1 
…fana#14447)
periklis added a commit to periklis/loki that referenced this pull request Oct 21, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
af4d141 
…fana#14447)
@periklis periklis mentioned this pull request Oct 22, 2024
Merged
6 tasks
periklis added a commit to periklis/loki that referenced this pull request Oct 22, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
0617d2e 
…fana#14447)
periklis added a commit to periklis/loki that referenced this pull request Oct 22, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
f39c7d1 
…fana#14447)
periklis added a commit to periklis/loki that referenced this pull request Oct 23, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
4cd7380 
…fana#14447)
periklis added a commit to periklis/loki that referenced this pull request Oct 23, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
da39a93 
…fana#14447)
periklis added a commit to openshift/loki that referenced this pull request Oct 24, 2024
@periklis
Merge pull request #375 from periklis/backport-pr-14447-6.0
31d5bce 
[release-6.0] Backport PR grafana#14447
periklis added a commit to openshift/loki that referenced this pull request Oct 24, 2024
@periklis
Merge pull request #376 from periklis/backport-pr-14447-5.8
24d7508 
[release-5.8] Backport PR grafana#14447
periklis added a commit to periklis/loki that referenced this pull request Oct 24, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
0e3d892 
…fana#14447)
periklis added a commit to periklis/loki that referenced this pull request Oct 24, 2024
@periklis
refactor(operator)!: Migrate project layout to kubebuilder go/v4 (gra…
6c4b614 
…fana#14447)
periklis added a commit to openshift/loki that referenced this pull request Oct 24, 2024
@periklis
Merge pull request #381 from periklis/backport-pr-14447-5.9
a1c77d2 
[release-5.9] Backport PR grafana#14447
This was referenced Nov 4, 2024
Merged
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperimental xperimental xperimental left review comments

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding approved these changes

Assignees

@periklis periklis

Labels
sig/operator size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

operator: Update kustomize files to remove deprecated keywords/features
3 participants
@periklis @JoaoBraveCoding @xperimental