Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: Also dump systemd failed units on start #1790

Merged
merged 1 commit into from
Jun 8, 2020
Merged

daemon: Also dump systemd failed units on start #1790

merged 1 commit into from
Jun 8, 2020

Conversation

cgwalters
Copy link
Member

We really want dynamic visibility and cluster events/alerts on
this of course but let's start with this.

@cgwalters
daemon: Also dump systemd failed units on start
ede23fe 
We really want dynamic visibility and cluster events/alerts on
this of course but let's start with this.
@cgwalters
Copy link
Member Author

Only compile tested locally but it's a Go translation of https://github.com/coreos/console-login-helper-messages/blob/e8a849f4c23910e7c556c10719911cc59873fc23/usr/share/console-login-helper-messages/profile.sh

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
cgwalters added a commit to cgwalters/must-gather that referenced this pull request Jun 5, 2020
@cgwalters
gather_service_logs: Gather MCO host services
753124c 
Motivated by https://bugzilla.redhat.com/show_bug.cgi?id=1842906
and many prior bugs.  Also added a link to
openshift/machine-config-operator#1365
which I think would be a better fix for early cluster bringup.

Also xref openshift/machine-config-operator#1790
@cgwalters cgwalters mentioned this pull request Jun 5, 2020
Closed
yuqi-zhang
yuqi-zhang approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, although the output from systemctl list-units --state=running --no-legend is generally very minimal and doesn't tell us much. Its a good start I suppose

@sinnykumari
Copy link
Contributor

Useful information to capture for debugging, thanks for the PR!

/lgtm

Working as expected, log from one of the mcd pod:

I0605 21:44:16.907917    2264 rpm-ostree.go:368] Running captured: systemctl list-units --state=failed --no-legend
I0605 21:44:16.926361    2264 daemon.go:850] systemctl --failed:
afterburn-sshkeys@core.service loaded failed failed Afterburn (SSH Keys)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sinnykumari, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,sinnykumari,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4e4eb05 into openshift:master Jun 8, 2020
@cgwalters
Copy link
Member Author

Ah yes it is handy we currently have a failing service, though that one is on track to be fixed, see
https://gitlab.cee.redhat.com/coreos/redhat-coreos/-/merge_requests/972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@runcom runcom Awaiting requested review from runcom

Assignees

@sinnykumari sinnykumari

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cgwalters @sinnykumari @openshift-ci-robot @openshift-bot @yuqi-zhang @openshift-merge-robot