-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon: Also dump systemd failed units on start #1790
daemon: Also dump systemd failed units on start #1790
Conversation
We really want dynamic visibility and cluster events/alerts on this of course but let's start with this.
Only compile tested locally but it's a Go translation of https://github.com/coreos/console-login-helper-messages/blob/e8a849f4c23910e7c556c10719911cc59873fc23/usr/share/console-login-helper-messages/profile.sh |
Motivated by https://bugzilla.redhat.com/show_bug.cgi?id=1842906 and many prior bugs. Also added a link to openshift/machine-config-operator#1365 which I think would be a better fix for early cluster bringup. Also xref openshift/machine-config-operator#1790
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, although the output from systemctl list-units --state=running --no-legend
is generally very minimal and doesn't tell us much. Its a good start I suppose
Useful information to capture for debugging, thanks for the PR! /lgtm Working as expected, log from one of the mcd pod:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, sinnykumari, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Ah yes it is handy we currently have a failing service, though that one is on track to be fixed, see |
We really want dynamic visibility and cluster events/alerts on
this of course but let's start with this.