-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCS: change machine-config-server ports #368
MCS: change machine-config-server ports #368
Conversation
Don't we need to listen on both ports at least temporarily? See #166 (comment) |
+1 |
The problem is we'd need to land these PRs simultaneously for it to work, and there's no way to really do that today with our CI system. Also, we want to be nice to e.g. people who built an installer from a few days ago and are pulling a new update payload. So I think the path here is something like having the MCS listen on both ports, then merge the installer PR, and then drop the old port from this repo? |
Thanks @cgwalters @abhinavdahiya ! Will do! |
965dd9a
to
f46f297
Compare
f46f297
to
cdeadf8
Compare
/retest |
/retest |
/approve Sorry about changing this to WIP, I had missed the updated patch. Now let's talk about testing. As far as I understand it in order to get "real" coverage of this one would need to build a custom update payload and run it through the installer. I'm guessing you didn't do that (I tried and failed at that...need to get back to trying again). The test cases (e2e-aws and e2e-aws-op) though will boot a new cluster with this. Both are currently failing which could be flakes or could be real issues. At the moment it's only https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/368/pull-ci-openshift-machine-config-operator-master-e2e-aws/1455/artifacts/e2e-aws/bootstrap/bootkube.service Not much more info than that I can find though 😦. If for example the booted masters weren't able to contact the original port they'd end up stalling in Ignition and I don't think we have a way to get logs out of that scenario today (other than possibly calling out to EC2 to scrape the console?). |
cdeadf8
to
030ce74
Compare
/lgtm |
Thanks @abhinavdahiya , I'll update this tomorrow. |
030ce74
to
80029ee
Compare
/lgtm |
Transition machine-config-server ports from 49500/49501 -> 22623/22624 to avoid conflict with local port and node port ranges. Listeners added for legacy ports until installer transitions to using the new ports. Closes: openshift#166
80029ee
to
fcc7665
Compare
@cgwalters there is something wrong with CI so I repushed to try to kick it off and it removed your lgtm. Didn't help though. |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test e2e-aws-op |
e2e-aws now passes, attempting to get the e2e-aws-op test unstuck from yesterday's run... |
So e2e-aws-op successfully got thru bootstrap to master and workers but timed out. Seeing in master logs: /test e2e-aws-op |
@kikisdeliveryservice Thanks for this fix. I just ran into a conflict again on the (now legacy) port. Is there a separate issue tracking the removal of the legacy ports? Until they are fully removed, we still have the potential for problems where conflicts will prevent the machine config server from starting. If so, is there an ETA on when the legacy ports might be removed? |
We never GA'ed, the eta should still be before 4.0 afaict, let's have an issue tracking it |
@joelsmith The legacy port will be removed here once openshift/installer#1180 lands in the installer. |
Thanks |
Change machine-config-server ports from 49500/49501 -> 22623/22624
to avoid conflict with local port and node port ranges.
Closes: #166
Related-to: openshift/installer#1180