MCS: remove legacy servers & ports

[kikisdeliveryservice]

legacySecureServer and legacyInsecureServer were added to accommodate the
installer port references when we transitioned the MCS ports from 49500/49501
to 22623/22624. The installer was updated via PR #1180 to use 22623/22624, so
we can now remove the legacy server/port references.

Clean-up step for: #166
Related to: #368
Related-to: openshift/installer#1180

[runcom]

/lgtm

[cgwalters]

This looks good to me. One minor thing, would you mind adding the "topic prefix" like MCS: as you have in the PR title (I've been using daemon:, controller: or in this case server:) into the commit message title too?

One other thing I'd note is that while it should be safe from a CI perspective to do this right now, we will break anyone who e.g. is using an older installer and trying to do a new update payload. So when we make changes like this it might be nice to wait...I dunno, a week? But eh, I'm fine doing it now.

[runcom]

/lgtm cancel

due to Colin's comment above actually just to hash that out

[cgwalters]

(On the other hand, merging this will definitely fix known issues)

[ashcrow]

This looks good to me. One minor thing, would you mind adding the "topic prefix" like MCS: as you have in the PR title (I've been using daemon:, controller: or in this case server:) into the commit message title too?

👍

One other thing I'd note is that while it should be safe from a CI perspective to do this right now, we will break anyone who e.g. is using an older installer and trying to do a new update payload. So when we make changes like this it might be nice to wait...I dunno, a week? But eh, I'm fine doing it now.

I saw let's rip off the band aid now 😸

[cgwalters]

I saw let's rip off the band aid now smile_cat

Fine by me too!

[kikisdeliveryservice]

@cgwalters I just wanted to put the pr in now so that we wouldn't forget. I'm fine waiting too. I'll update my commit message and repush and let yall decide when it goes in. 😄

[kikisdeliveryservice]

/retest

[kikisdeliveryservice]

/test e2e-aws

[runcom]

/retest

[ashcrow]

Flakes

/retest

[cgwalters]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters,kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment