-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-31365: make verify should use MCO's kube version #4280
Conversation
/test verify |
@djoshy: This pull request references Jira Issue OCPBUGS-31365, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
/test all |
@djoshy: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
SETUP_ENVTEST := $(shell command -v setup-envtest 2> /dev/null) | ||
install-setup-envtest: | ||
ifdef SETUP_ENVTEST | ||
@echo "Found setup-envtest" | ||
else | ||
@echo "Installing setup-envtest" | ||
go install -mod= sigs.k8s.io/controller-runtime/tools/setup-envtest@latest | ||
go install -mod= sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240315194348-5aaf1190f880 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a comment so that we remember to update it instead of carrying over same version in future release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Should have checked https://github.com/kubernetes-sigs/controller-runtime/tree/main/tools/setup-envtest repo earlier . It looks like this repo doesn't have each kube version specific branches. So, let's remove the comment (sorry, should have checked earlier)
As per kubernetes-sigs/controller-runtime@4c2442e Go bump to 1.22 was added because kube 1.30 needs that. We can backport this PR to older version as it is and create a story targeted to 4.17 where we would bump kube to 1.30 to use latest tag.
/lgtm |
/lgtm cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
caeefea
into
openshift:master
@djoshy: Jira Issue OCPBUGS-31365: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31365 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@djoshy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherrypick release-4.15 |
@djoshy: new pull request created: #4282 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-config-operator-container-v4.16.0-202403251813.p0.gcaeefea.assembly.stream.el8 for distgit ose-machine-config-operator. |
- What I did
Hardcoded setup-envtools to a version right before the go bump to 1.22. As a result, this will have to manually updated along with a kube bump to keep up as we will no longer be using the @latest tag
- How to verify it
make verify
should pass