Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-31365: make verify should use MCO's kube version #4280

Merged
merged 1 commit into from
Mar 25, 2024
Merged

OCPBUGS-31365: make verify should use MCO's kube version #4280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ ifdef SETUP_ENVTEST
@echo "Found setup-envtest"
else
@echo "Installing setup-envtest"
go install -mod= sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go install -mod= sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240315194348-5aaf1190f880
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment so that we remember to update it instead of carrying over same version in future release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Should have checked https://github.com/kubernetes-sigs/controller-runtime/tree/main/tools/setup-envtest repo earlier . It looks like this repo doesn't have each kube version specific branches. So, let's remove the comment (sorry, should have checked earlier)
As per kubernetes-sigs/controller-runtime@4c2442e Go bump to 1.22 was added because kube 1.30 needs that. We can backport this PR to older version as it is and create a story targeted to 4.17 where we would bump kube to 1.30 to use latest tag.

endif

GO_JUNIT_REPORT := $(shell command -v go-junit-report 2> /dev/null)
Expand Down