Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: parks-app crashes after being restored when hitting the api #646

Closed
1 task done
weshayutin opened this issue Apr 22, 2022 · 6 comments · Fixed by #649 or #654
Closed
1 task done

Bug: parks-app crashes after being restored when hitting the api #646

weshayutin opened this issue Apr 22, 2022 · 6 comments · Fixed by #649 or #654
Assignees
@weshayutin
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@weshayutin
Copy link
Contributor

Contact Details

whayutin@redhat.com

Describe bug

parks-app is OLD... afaict it's only value is mongodb.
https://github.com/openshift/oadp-operator/tree/master/tests/e2e/sample-applications/parks-app

Let's replace parks app w/ the same app we use for mariadb (todolist).
This will allow for data validation across db backends

We have the todolist app working with MongoDB.
https://github.com/weshayutin/todolist-mongo-go

What happened?

A bug happened!

OADP Version

1.0.1 (Stable)

OpenShift Version

4.10

Velero pod logs

No response

Restic pod logs

No response

Operator pod logs

No response

New issue

  • This issue is new
@weshayutin weshayutin added the kind/bug Categorizes issue or PR as related to a bug. label Apr 22, 2022
@weshayutin weshayutin self-assigned this Apr 22, 2022
@weshayutin
Copy link
Contributor Author

@deepakraj1997 @hhpatel14 FYI

@deepakraj1997
Copy link
Contributor

deepakraj1997 commented Apr 22, 2022 •
edited
Loading

Further debug of this issue:

after i did a backup and restore, we have the same pods running initially but after i hit the parks REST API, it doesnt work, however, another deployment get triggered due to a change in build config: https://github.com/openshift/oadp-operator/blob/master/tests/e2e/sample-applications/parks-app/manifest4.8.yaml#L69-L77

After restore
image

Hitting the API
image

New Deployment trigger
image

After this it works.

@kaovilai
Copy link
Member

I think the verification function should wait a few seconds and only check the last deployment (restify-2).

@kaovilai
Copy link
Member

Whatever replacement is should remains a deploymentconfig with buildconfig which is a usecase that OADP currently requires a workaround on to restore successfully.

@weshayutin
Copy link
Contributor Author

weshayutin commented Apr 22, 2022 •
edited
Loading

oh @kaovilai so just to make sure I 100% understand what you are saying...
Replace the container definition in the manifest and have the app built via an openshift build-config.
Is that correct? Happy to do it if so.

@kaovilai
Copy link
Member

Yes. That would be great!

weshayutin added a commit to weshayutin/oadp-operator that referenced this issue Apr 28, 2022
@weshayutin
replace the parks-app with todolist on mongo
614a19c 
* created a version of todolist for mongo
* ensure the manifest builds and triggers just like
the parks-app did
* adv is that the same app api can be used to add
data to the db and check after restore. Related PR
openshift#624

Resolves: openshift#646
@weshayutin weshayutin mentioned this issue Apr 28, 2022
Merged
@kaovilai kaovilai mentioned this issue May 1, 2022
Merged
8 tasks
weshayutin added a commit to weshayutin/oadp-operator that referenced this issue May 3, 2022
@weshayutin
replace the parks-app with todolist on mongo
5f6b1bf 
* created a version of todolist for mongo
* ensure the manifest builds and triggers just like
the parks-app did
* adv is that the same app api can be used to add
data to the db and check after restore. Related PR
openshift#624

Resolves: openshift#646
weshayutin added a commit to weshayutin/oadp-operator that referenced this issue May 3, 2022
@weshayutin
replace the parks-app with todolist on mongo
6d1eb5d 
* created a version of todolist for mongo
* ensure the manifest builds and triggers just like
the parks-app did
* adv is that the same app api can be used to add
data to the db and check after restore. Related PR
openshift#624

Resolves: openshift#646
kaovilai pushed a commit that referenced this issue May 3, 2022
@weshayutin
replace the parks-app with todolist on mongo (#649)
dfa7af9 
* created a version of todolist for mongo
* ensure the manifest builds and triggers just like
the parks-app did
* adv is that the same app api can be used to add
data to the db and check after restore. Related PR
#624

Resolves: #646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weshayutin weshayutin

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
3 participants
@weshayutin @kaovilai @deepakraj1997