-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace the parks-app with todolist on mongo #649
Conversation
/hold WIP |
LGTM, Thank you for putting this up. Do we want to check CSI template as well as part of this ? |
@deepakraj1997 We could use the CSI version but we should do add that row of test data in a new PR. |
@weshayutin mongo-persistent-csi-template.yaml template looks good. I can add new PR after this for CSI. |
/lgtm |
/unhold |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are using the same manifests for all ocp versions, we don't need to separate the entries.
Have PR of requested changes here weshayutin#1 |
New changes are detected. LGTM label has been removed. |
* created a version of todolist for mongo * ensure the manifest builds and triggers just like the parks-app did * adv is that the same app api can be used to add data to the db and check after restore. Related PR openshift#624 Resolves: openshift#646
@kaovilai THANK YOU! for you help reviewing this one :) |
/retest |
@weshayutin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
the parks-app did
data to the db and check after restore. Related PR
Adding function to verify Backup / Restore data #624
Resolves: #646