-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-535 allow for nullable resource allocations #711
Conversation
/cherrypick oadp-1.0 |
@kaovilai: once the present PR merges, I will cherry-pick it on top of oadp-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -216,6 +216,7 @@ spec: | |||
x-kubernetes-int-or-string: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need nullable: true
on line number 209 as well as on line number 353.
@@ -208,6 +208,7 @@ spec: | |||
resourceAllocations: | |||
description: ResourceAllocations defines the CPU and Memory | |||
resource allocations for the restic Pod | |||
nullable: true | |||
properties: | |||
limits: | |||
additionalProperties: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need nullable: true
specifically for limits as well as requests ?
/cherrypick oadp-1.0 |
@dymurray: once the present PR merges, I will cherry-pick it on top of oadp-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -216,6 +217,7 @@ spec: | |||
x-kubernetes-int-or-string: true | |||
description: 'Limits describes the maximum amount | |||
of compute resources allowed. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/' | |||
nullable: true | |||
type: object | |||
requests: | |||
additionalProperties: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs nullable
for the additionalProperties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, thank you for the fix!
/lgtm |
@dymurray: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherrypick oadp-1.0 |
@kaovilai: new pull request created: #715 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dymurray: new pull request could not be created: failed to create pull request against openshift/oadp-operator#oadp-1.0 from head openshift-cherrypick-robot:cherry-pick-711-to-oadp-1.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-711-to-oadp-1.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* OADP-535 allow for nullable resource allocations * Add missing nullables * Include nullable on additionalProperties
…p (fix azure flakes) (#717) * revert to b64e96e * bump probe to 10s * mimic velero cli loglevel options (#692) use logrus ParseLevel directly * Fix OADP 526 (#704) * fix OADP 526 * add ignore err comments * fix docs link for build from src (#706) * Datamover CRD design (#597) * Adding initial datamover design * Typo in reviewers * Add summary & user stories * Fixing nits * Adding intial feedback * Adding feedback * nit: changing the selector field name * Adding review comments * Adding plugin clarification * updating image to reflect the latest design * Reflect recent velero csi plugin changes * use a full vm for arm builds in travis (#713) * OADP-535 allow for nullable resource allocations (#711) * OADP-535 allow for nullable resource allocations * Add missing nullables * Include nullable on additionalProperties Co-authored-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com> Co-authored-by: Savitha Raghunathan <sraghuna@redhat.com> Co-authored-by: Jason Montleon <jmontleo@redhat.com> Co-authored-by: Dylan Murray <dymurray@redhat.com>
This change allows for null resource allocations fields.
NOTE this includes a manual update to the DPA CRD to allow for
null
requests and allocations fields. This means thatmake manifests
will no longer give us exactly what we need and will require folks to constantly add it back in. We need to figure out a better path forward for this.OADP-535