Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NoDefaultBackupLocation e2e entry + registry probe timeout bump (fix azure flakes) #717

Merged
merged 8 commits into from
Jun 3, 2022
Merged

Remove NoDefaultBackupLocation e2e entry + registry probe timeout bump (fix azure flakes) #717

merged 8 commits into from
Jun 3, 2022

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented May 31, 2022 •
edited

  • revert to b64e96e
    • verify test passes 3 times
    • ignore github actions failure, separate PR.
  • fix azure flake by bumping registry probe timeout 75c8b51
  • cherrypick other reverted commits after b64e96e on top except nodefaultbackuplocation e2e
  • In follow-up PRs
    • add working nodefaultbackuplocation e2e test case this time.
      • minimal refactoring for a valid test case.
    • refactoring tests to a better state.

@kaovilai kaovilai mentioned this pull request May 31, 2022
Closed
@kaovilai
Copy link
Member Author

kaovilai commented May 31, 2022 •
edited

azure registry probe flake #1
#2
fix here https://github.com/openshift/oadp-operator/pull/710/files#diff-14341d832b55f374f353d693c68774d04617876f76c0de474e91763d14594614R372
without this fix we just gonna have to retest azure couple times after every commit

@kaovilai
Copy link
Member Author

/retest
check azure can sometimes pass

@kaovilai
Copy link
Member Author

kaovilai commented Jun 1, 2022

/test 4.7-operator-e2e-azure

@kaovilai kaovilai changed the title redo: nodefaultbackuplocation e2e Remove NoDefaultLocation e2e entry + registry probe timeout bump (fix azure flakes) Jun 1, 2022
@kaovilai kaovilai changed the title Remove NoDefaultLocation e2e entry + registry probe timeout bump (fix azure flakes) Remove NoDefaultBackupLocation e2e entry + registry probe timeout bump (fix azure flakes) Jun 1, 2022
@kaovilai
Copy link
Member Author

kaovilai commented Jun 1, 2022

/test 4.9-operator-e2e-azure

infra flake

@kaovilai
Copy link
Member Author

kaovilai commented Jun 1, 2022

ci azure infra create failure. trying again tmr

@kaovilai
Copy link
Member Author

kaovilai commented Jun 1, 2022

/retest

@kaovilai
Copy link
Member Author

kaovilai commented Jun 1, 2022

cherrypicking time :D

kaovilai and others added 6 commits June 1, 2022 10:38
@kaovilai
mimic velero cli loglevel options (openshift#692)
7ea39e3 
use logrus ParseLevel directly
@shubham-pampattiwar @kaovilai
Fix OADP 526 (openshift#704)
7ea5b67 
* fix OADP 526

* add ignore err comments
@shubham-pampattiwar @kaovilai
fix docs link for build from src (openshift#706)
934bb18
@savitharaghunathan @kaovilai
Datamover CRD design (openshift#597)
e94cc4e 
* Adding initial datamover design

* Typo in reviewers

* Add summary & user stories

* Fixing nits

* Adding intial feedback

* Adding feedback

* nit: changing the selector field name

* Adding review comments

* Adding plugin clarification

* updating image to reflect the latest design

* Reflect recent velero csi plugin changes
@jmontleon @kaovilai
use a full vm for arm builds in travis (openshift#713)
bc0af57
@dymurray @kaovilai
OADP-535 allow for nullable resource allocations (openshift#711)
771df34 
* OADP-535 allow for nullable resource allocations

* Add missing nullables

* Include nullable on additionalProperties
@kaovilai
Copy link
Member Author

kaovilai commented Jun 1, 2022

infra flake
/test 4.9-operator-e2e-azure

@weshayutin
Copy link
Contributor

/LGTM

@weshayutin
Copy link
Contributor

@hhpatel14 please have a double check

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dymurray
dymurray approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaovilai kaovilai merged commit 09024d8 into openshift:master Jun 3, 2022
@kaovilai kaovilai mentioned this pull request Jun 10, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray approved these changes

@rayfordj rayfordj Awaiting requested review from rayfordj

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

Assignees

@weshayutin weshayutin

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kaovilai @weshayutin @dymurray @shubham-pampattiwar @savitharaghunathan @jmontleon