Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1872080: Updating images/Dockerfile.rhel7 baseimages to mach ocp-build-data config #17

Conversation

openshift-bot
Copy link
Contributor

This PR is autogenerated by the ocp-build-data-enforcer.
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the ocp-build-data repository used
for producing release artifacts.

If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.

@jupierce jupierce changed the title Updating images/Dockerfile.rhel7 baseimages to mach ocp-build-data config Bug 1872080: Updating images/Dockerfile.rhel7 baseimages to mach ocp-build-data config Aug 25, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: Updating images/Dockerfile.rhel7 baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jupierce
Copy link

/retest

@yselkowitz
Copy link

/assign @deads2k

@sttts
Copy link
Contributor

sttts commented Aug 27, 2020

/hold

We will remove the hold as soon as the opt-out mechanism for the Golang version is available and we have opted-out.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2020
@jupierce
Copy link

jupierce commented Sep 1, 2020

/retest

1 similar comment
@jupierce
Copy link

jupierce commented Sep 2, 2020

/retest

@sttts
Copy link
Contributor

sttts commented Sep 3, 2020

With 1.15 there will be a new PR switching this to explicit versions, with an option to opt-out by holding that.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2020
@sttts
Copy link
Contributor

sttts commented Sep 3, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2020
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2020
…nfig

This PR is autogenerated by the [ocp-build-data-enforcer][1].
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the [ocp-build-data repository][2] used
for producing release artifacts.

If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.

[1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer
[2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
@crawford crawford force-pushed the updating-images/dockerfile.rhel7-baseimages-to-mach-ocp-build-data-config branch from 1b19597 to 5efd211 Compare September 8, 2020 14:00
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 8, 2020
@p0lyn0mial
Copy link
Contributor

the oauth-apiserver binary doesn't run because versionFromGit is not set.
The variable is set from ldflags during compilation.

compare https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_oauth-apiserver/17/pull-ci-openshift-oauth-apiserver-master-e2e-aws/1298755373695504384/artifacts/build-logs/oauth-apiserver.log vs https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_oauth-apiserver/17/pull-ci-openshift-oauth-apiserver-master-e2e-aws/1303332393255440384/artifacts/build-logs/oauth-apiserver.log.

the version is set by the build-machinery-go but the new image is overriding SOURCE_GIT_TAG to an empty string

@p0lyn0mial
Copy link
Contributor

/retest

@p0lyn0mial
Copy link
Contributor

the based image was fixed by openshift-eng/ocp-build-data@fc69783

@crawford
Copy link

could not run steps: step e2e-aws failed: "e2e-aws" post steps failed: "e2e-aws" pod "e2e-aws-gather-must-gather" failed: pod didn't start running within 10 minutes

Boooo. Tests passed. The must-gather failed to schedule.

@crawford
Copy link

I'm adding the LGTM label back since there were no changes in my latest rebase.

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, openshift-bot, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link

As noted in #17 (comment), the tests themselves have passed. It was the CI infrastructure that had some trouble. Given the schedule requirements we are facing, I'm not going to wait around for this to pass. The change works. Let's move on.

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link
Contributor

@crawford: Overrode contexts on behalf of crawford: ci/prow/e2e-aws

In response to this:

As noted in #17 (comment), the tests themselves have passed. It was the CI infrastructure that had some trouble. Given the schedule requirements we are facing, I'm not going to wait around for this to pass. The change works. Let's move on.

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4702a2d into openshift:master Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

In response to this:

Bug 1872080: Updating images/Dockerfile.rhel7 baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants