Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that reencrypt is supported for registry routes #10519

Merged
merged 1 commit into from
Jul 3, 2018
Merged

clarify that reencrypt is supported for registry routes #10519

merged 1 commit into from
Jul 3, 2018

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jun 28, 2018

No description provided.

@bparees
Copy link
Contributor Author

bparees commented Jun 28, 2018

3.7+ only.

@openshift/team-documentation ptal

@mburke5678
Copy link
Contributor

mburke5678 commented Jun 29, 2018

@bparees Do we need to explain how to configure reencrypt routes here? (We don't seem to explain this elsewhere in the docs.
If not, one nit and LGTM.

Can you suggest an appropriate QE resource for review? Perhaps @wzheng1

@@ -268,8 +268,7 @@ DNS to the router's IP address.
+
[NOTE]
====
Passthrough is currently the only type of route supported for exposing the
secure registry.
Reencrypt routes are also supported for exposing the secure registry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Reencrypt/Re-encrypt
(we seem to use the hyphenated version)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@bparees
Copy link
Contributor Author

bparees commented Jun 29, 2018

Do we need to explain how to configure reencrypt routes here? (We don't seem to explain this elsewhere in the docs.

no i don't think this is the right place to cover that, but if it's really something we don't document anywhere, a new bug should be opened for the networking team to add documentation for it.

@mburke5678
Copy link
Contributor

@bparees I found one reference here:
These self-signed certificates are not recognized by browsers. To mitigate this issue, use a publicly signed certificate, then configure it to re-encrypt traffic with the self-signed certificate. With steps to use oc create route reencrypt
https://docs.openshift.com/container-platform/3.9/day_two_guide/certificate_management.html#change-app-cert-to-ca-signed-cert

@bparees
Copy link
Contributor Author

bparees commented Jul 3, 2018

@mburke5678 so can this merge?

@mburke5678
Copy link
Contributor

@bparees We usually ask that a QE resource also review. is there someone you can recommend?

@bmcelvee
Copy link
Contributor

bmcelvee commented Jul 3, 2018

@mburke5678 This is such a minor change I don't think it needs QE 😸

@bparees
Copy link
Contributor Author

bparees commented Jul 3, 2018

@mburke5678
Copy link
Contributor

@bparees I just wanted a "second opinion" that reencrypt routes are supported as we are stating. But, if we are all OK, with it, based on the BZ, I can merge away!

@mburke5678
Copy link
Contributor

@bparees Do we want to add this info to the 3.7 release notes?
#10606

@bparees
Copy link
Contributor Author

bparees commented Jul 3, 2018

@bparees Do we want to add this info to the 3.7 release notes?

i guess

@mburke5678 mburke5678 merged commit 8f93416 into openshift:master Jul 3, 2018
@mburke5678
Copy link
Contributor

/cherrypick enterprise-3.7

@openshift-cherrypick-robot

@mburke5678: new pull request created: #10607

In response to this:

/cherrypick enterprise-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-3.9

@openshift-cherrypick-robot

@mburke5678: new pull request created: #10608

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-3.10

@openshift-cherrypick-robot

@mburke5678: new pull request created: #10609

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678 mburke5678 added this to the Next Release milestone Jul 3, 2018
@bparees bparees deleted the reencrypt branch February 27, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants