-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify that reencrypt is supported for registry routes #10519
Conversation
3.7+ only. @openshift/team-documentation ptal |
@@ -268,8 +268,7 @@ DNS to the router's IP address. | |||
+ | |||
[NOTE] | |||
==== | |||
Passthrough is currently the only type of route supported for exposing the | |||
secure registry. | |||
Reencrypt routes are also supported for exposing the secure registry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Reencrypt/Re-encrypt
(we seem to use the hyphenated version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
no i don't think this is the right place to cover that, but if it's really something we don't document anywhere, a new bug should be opened for the networking team to add documentation for it. |
@bparees I found one reference here: |
@mburke5678 so can this merge? |
@bparees We usually ask that a QE resource also review. is there someone you can recommend? |
@mburke5678 This is such a minor change I don't think it needs QE 😸 |
for what it's worth this was closed out via https://bugzilla.redhat.com/show_bug.cgi?id=1464562 |
@bparees I just wanted a "second opinion" that reencrypt routes are supported as we are stating. But, if we are all OK, with it, based on the BZ, I can merge away! |
i guess |
/cherrypick enterprise-3.7 |
@mburke5678: new pull request created: #10607 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.9 |
@mburke5678: new pull request created: #10608 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.10 |
@mburke5678: new pull request created: #10609 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.