Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase to Docker Distribution v2.6.2 #15694

Merged

Conversation

dmage
Copy link
Member

@dmage dmage commented Aug 9, 2017

No description provided.

@openshift-merge-robot openshift-merge-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 9, 2017
@deads2k
Copy link
Contributor

deads2k commented Aug 9, 2017

/assign mfojtik
/assign miminar
/unassign

@openshift-ci-robot openshift-ci-robot assigned mfojtik and miminar and unassigned deads2k Aug 9, 2017
@stevekuznetsov
Copy link
Contributor

/unassign

dmage and others added 5 commits August 9, 2017 17:04
Add support for custom routes and custom auth records per route.
….enter

In some conditions, regulator.exit may not send a signal to blocked
regulator.enter.

Let's assume we are in the critical section of regulator.exit and r.available
is equal to 0. And there are three more gorotines. One goroutine also executes
regulator.exit and waits for the lock. Rest run regulator.enter and wait for
the signal.

We send the signal, and after releasing the lock, there will be lock
contention:

  1. Wait from regulator.enter
  2. Lock from regulator.exit

If the winner is Lock from regulator.exit, we will not send another signal to
unlock the second Wait.

Signed-off-by: Oleg Bulatov <obulatov@redhat.com>
@dmage
Copy link
Member Author

dmage commented Aug 9, 2017

flake #14772
/test extended_conformance_install_update

@dmage
Copy link
Member Author

dmage commented Aug 9, 2017

/retest

@dmage
Copy link
Member Author

dmage commented Aug 9, 2017

flake #15715

@dmage
Copy link
Member Author

dmage commented Aug 10, 2017

/retest

@dmage
Copy link
Member Author

dmage commented Aug 10, 2017

flake #8571
/retest

@dmage
Copy link
Member Author

dmage commented Aug 10, 2017

/retest

1 similar comment
@dmage
Copy link
Member Author

dmage commented Aug 10, 2017

/retest

@miminar
Copy link

miminar commented Aug 14, 2017

/test extended_image_registry

@@ -0,0 +1,22 @@
The packages in this directory represent dependencies that differ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need this commit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a brief description from 41f478a about why this vendor/ subdirectory exists and how one can recreate it. I found it useful when I was doing rebase. And yes, it another proof that we constantly loose changes related to distribution.

@mfojtik
Copy link
Contributor

mfojtik commented Aug 16, 2017

/approve

we should get the extended registry test working before merging this. also we should consider fork_ami and give the QA something to test before merging as well?

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2017
@dmage
Copy link
Member Author

dmage commented Aug 16, 2017

Submit Queue — PR does not have lgtm label.

It seems the robot isn't going to wait for the green extended test, so I add the do-not-merge label.

@mfojtik
Copy link
Contributor

mfojtik commented Aug 16, 2017

@dmage without lgtm label nothing is going to be merged.

@miminar
Copy link

miminar commented Aug 16, 2017

@0xmichalis
Copy link
Contributor

It seems the robot isn't going to wait for the green extended test, so I add the do-not-merge label.

Yes, these extended test are not merge-blocking today. Upstream issue: kubernetes/test-infra#3740

@legionus
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, legionus, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dmage
Copy link
Member Author

dmage commented Aug 29, 2017

flake #16025

@dmage
Copy link
Member Author

dmage commented Aug 29, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dmage
Copy link
Member Author

dmage commented Aug 30, 2017

/retest

@dmage
Copy link
Member Author

dmage commented Aug 30, 2017

/test extended_conformance_gce

@dmage
Copy link
Member Author

dmage commented Aug 31, 2017

flake #16023
/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 31, 2017

@dmage: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_image_registry e6bc3b6 link /test extended_image_registry

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link
Contributor

mfojtik commented Aug 31, 2017

/test extended_image_registry

@dmage
Copy link
Member Author

dmage commented Aug 31, 2017

flake #12273
/test extended_conformance_gce

@dmage
Copy link
Member Author

dmage commented Aug 31, 2017

flake #14228

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/imageregistry lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants