Update 3.11 for openshift start / hyperkube changes
#21268
Conversation
adellape
force-pushed
the
startnode311_2
branch
from
b03989e
to
3ffde0b
Compare
|
@deads2k Could you PTAL at this 3.11 docs fix re: Origin issue "Remove openshift start node and cut kubelet dependencies" openshift/origin#20344 so we can get it merged? Thank you! |
adellape
added
peer-review-needed
|
Adding peer review acks as they were given in the original PR #18691. |
|
@wangke19 Can you take a look at this for QE review, please? Thank you! |
|
I will ask @xingxingxia to review together. |
There was a problem hiding this comment.
@adellape Hi, LGTM except the inline comments. For some lines which are not in my areas (my areas are Master / Apiserver), already requested related subteams QE inline to double confirm.
| xref:../architecture/infrastructure_components/kubernetes_infrastructure.adoc#master[master configuration file], | ||
| at *_/etc/origin/master/master-config.yaml_*, and the | ||
| xref:../admin_guide/manage_nodes.adoc#modifying-nodes[node configuration maps]. |
There was a problem hiding this comment.
Can you double confirm these other doc pages are desired? I just see these configuration file or configuration maps are in the same doc page ../install_config/master_node_configuration.html
| @@ -1784,11 +1777,17 @@ master-logs api api 2> file | |||
| [[master-node-config-logging-levels]] | |||
| === Configuring Logging Levels | |||
|
|
|||
| You can control which INFO messages are logged by setting the `DEBUG_LOGLEVEL` option in the in xref:../admin_guide/manage_nodes.adoc#modifying-nodes[node configuration files] or the */etc/origin/master/master.env* file. Configuring the logs to collect all messages can lead to large logs that are difficult to interpret and can take up excessive space. Only collect all messages when you need to debug your cluster. | |||
| You can control which INFO messages are logged by setting the `DEBUG_LOGLEVEL` | |||
| option in the in xref:../admin_guide/manage_nodes.adoc#modifying-nodes[node configuration files] | |||
There was a problem hiding this comment.
Strange wording in the in
There was a problem hiding this comment.
I didn't see admin_guide/manage_nodes.adoc#modifying-nodes mentions log level, is this link good?
There was a problem hiding this comment.
Fixed typo and removed link.
| $ openshift start network \ | ||
| --config=/openshift.local.config/node-<node_hostname>/node-config.yaml \ | ||
| --kubeconfig=/openshift.local.config/node-<node_hostname>/node.kubeconfig |
There was a problem hiding this comment.
I'd like to request Networking QE @zhaozhanqi to double confirm for openshift start network
| $ hyperkube kubelet \ | ||
| $(/usr/bin/openshift-node-config \ | ||
| --config=/openshift.local.config/node-<node_hostname>/node-config.yaml) |
Reopening #18691 against
enterprise-3.11branch.Original description:
Fixes #11751.
Per https://github.com/openshift/origin/releases/tag/v3.11.0:
Preview (internal):