-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove openshift start node
and cut kubelet dependencies
#20344
Remove openshift start node
and cut kubelet dependencies
#20344
Conversation
728864e
to
4b3bf59
Compare
/test gcp |
4b3bf59
to
20cf431
Compare
/test gcp |
3 similar comments
/test gcp |
/test gcp |
/test gcp |
/retest |
@deads2k this is ready for review |
@smarterclayton I'm ready if you are. 3.11? /test all |
20cf431
to
4ba500a
Compare
27e65c9
to
62ce9e5
Compare
I think we should do this in 3.11 |
@@ -84,6 +85,19 @@ func NewCommandStartMaster(basename string, out, errout io.Writer) (*cobra.Comma | |||
Long: fmt.Sprintf(masterLong, basename), | |||
Run: func(c *cobra.Command, args []string) { | |||
kcmdutil.CheckErr(options.Complete()) | |||
|
|||
if options.PrintIP { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually this will go away too. Why move it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need it for like a billion test cases and tests. Everything using start went to using start master, so I moved it here.
"github.com/openshift/origin/pkg/version" | ||
) | ||
|
||
type NodeOptions struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name isn't correct anymore
test/util/server/server.go
Outdated
@@ -422,7 +328,7 @@ func StartConfiguredNode(nodeConfig *configapi.NodeConfig, components *utilflags | |||
return err | |||
} | |||
|
|||
if err := start.StartNode(*nodeConfig, components, wait.NeverStop); err != nil { | |||
if err := start.StartNode(*nodeConfig, components); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is starting the network?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can rename.
Some questions. Nothing fundamental. |
62ce9e5
to
55fd30f
Compare
55fd30f
to
0ac2242
Compare
Did the renames |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The kubelet is now only launched via
hyperkube kubelet
. Removeopenshift start
.