Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-3194: Adding AWS on ARM as a choice target cluster #40786

Merged
merged 1 commit into from
Feb 15, 2022
Merged

OSDOCS-3194: Adding AWS on ARM as a choice target cluster #40786

merged 1 commit into from
Feb 15, 2022

Conversation

kelbrown20
Copy link
Contributor

@kelbrown20 kelbrown20 commented Jan 19, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2022
@netlify
Copy link

netlify bot commented Jan 19, 2022 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: c6b745d

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6201686a2c5404000721d375

😎 Browse the preview: https://deploy-preview-40786--osdocs.netlify.app

@kelbrown20 kelbrown20 force-pushed the OSDOCS-3191-highlight-arm-as-a-choice branch from 5c9c43b to a496403 Compare January 26, 2022 19:15
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2022
@kelbrown20 kelbrown20 force-pushed the OSDOCS-3191-highlight-arm-as-a-choice branch from a496403 to f904ca7 Compare January 28, 2022 19:34
@kelbrown20
Copy link
Contributor Author

@SaravanaStorageNetwork. Thank you for your feedback! That change can be found in this PR: https://github.com/openshift/openshift-docs/pull/41036/files

@kelbrown20
Copy link
Contributor Author

kelbrown20 commented Feb 4, 2022 •
edited
Loading

Do we think that
Amazon Web Services (AWS) on arm64 instances and
AWS (arm64)
Looks better? I know arm64 and aarch64 are interchangeable but I was thinking about which one might look better

@kelbrown20 kelbrown20 force-pushed the OSDOCS-3191-highlight-arm-as-a-choice branch from f904ca7 to b05b2ab Compare February 4, 2022 16:07
@jeffdyoung
Copy link

Yeah, arm64 is cleaner and consistent with the use of arm64 in the install-config.yaml

@kelbrown20 kelbrown20 force-pushed the OSDOCS-3191-highlight-arm-as-a-choice branch from b05b2ab to c6b745d Compare February 7, 2022 18:43
@jeffdyoung
Copy link

👍 from devel.

@shivanthi-amara
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2022
@ahardin-rh ahardin-rh added branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 15, 2022
@ahardin-rh ahardin-rh added this to the Future Release milestone Feb 15, 2022
@ahardin-rh
Copy link
Contributor

LGTM!

@ahardin-rh ahardin-rh merged commit 8599664 into openshift:main Feb 15, 2022
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 15, 2022
Merged
@openshift-cherrypick-robot
Copy link

@ahardin-rh: new pull request created: #41953

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru modified the milestones: Future Release, OCP 4.10 GA Mar 10, 2022
@mjpytlak mjpytlak mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shivanthi-amara shivanthi-amara

Labels
branch/enterprise-4.10 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.10 GA
Development

Successfully merging this pull request may close these issues.
6 participants
@kelbrown20 @jeffdyoung @shivanthi-amara @ahardin-rh @openshift-cherrypick-robot @bobfuru