-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2064395: Fixed formatting for install support matrix in OKD and added missing entries #43337
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: b3c2e4f 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/62337029b457d30009b27b58 😎 Browse the preview: https://deploy-preview-43337--osdocs.netlify.app |
18048ad
to
b3c2e4f
Compare
/retitle Bug 2064395: Fixed formatting for install support matrix in OKD and added missing entries |
@mjpytlak: This pull request references Bugzilla bug 2064395, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@vrutkovs: This pull request references Bugzilla bug 2064395, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yunjiang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM, thanks! |
@yunjiang29 Please take a quick look at the OCP preview link. Given the 4.10 work that separated the GovCloud and Top Secret Region content into two help topics, I added a Secret regions row for AWS. |
@yunjiang29 Could you take a quick look at this? I would like to get the corrections published. Thanks in advance. |
@mjpytlak LGTM, thanks |
@mjpytlak LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mjpytlak: Bugzilla bug 2064395 is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.11 |
@lpettyjo: new pull request created: #43687 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.10 |
@lpettyjo: new pull request created: #43688 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lpettyjo: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.10 from head openshift-cherrypick-robot:cherry-pick-43337-to-enterprise-4.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.10 and openshift-cherrypick-robot:cherry-pick-43337-to-enterprise-4.10"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CP to 4.10 and 4.11
This PR addresses BZ2064395
Beginning with 4.10, AWS supports an arm64 IPI installation and bare metal supports an arm64 UPI installation. As such, updates where made to the IPI[1] and UPI[2] tables in Selecting a cluster installation method and preparing it for users > Supported installation methods for different platforms section.
The latter updates inadvertently broke the table in the OKD version of the doc. While the OCP version of the table requires a column for x86_64 and arm64 for AWS and bare metal, the OKD version does not. The additional table row added to accommodate arm64 resulted in tables row shifting in the OKD.
To resolve the discrepancy, this PR introduces a separate OKD table for both IPI and UPI. This is a deliberate design choice, as adding additional conditional statements to the shared table would only further complicate future updates.
Updates include the following:
OKD preview
Supported installation methods for different platforms
OCP preview
Supported installation methods for different platforms
[1] #40786
[2] #41149