Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2064395: Fixed formatting for install support matrix in OKD and added missing entries #43337

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

mjpytlak
Copy link
Contributor

@mjpytlak mjpytlak commented Mar 16, 2022

CP to 4.10 and 4.11

This PR addresses BZ2064395

Beginning with 4.10, AWS supports an arm64 IPI installation and bare metal supports an arm64 UPI installation. As such, updates where made to the IPI[1] and UPI[2] tables in Selecting a cluster installation method and preparing it for users > Supported installation methods for different platforms section.

The latter updates inadvertently broke the table in the OKD version of the doc. While the OCP version of the table requires a column for x86_64 and arm64 for AWS and bare metal, the OKD version does not. The additional table row added to accommodate arm64 resulted in tables row shifting in the OKD.

To resolve the discrepancy, this PR introduces a separate OKD table for both IPI and UPI. This is a deliberate design choice, as adding additional conditional statements to the shared table would only further complicate future updates.

Updates include the following:

  • OKD: Fixed the formatting in Table 1. Installer-provisioned infrastructure options. Added a column for Azure Stack Hub. OKD supports ASH in 4.10. The lack of an entry in this table was an oversight.
  • OKD: Fixed the formatting in Table 2. User-provisioned infrastructure options.
  • OCP and OKD: Added a row for Secret regions in Table 1. Beginning with 4.10, the AWS Government and Top Secret Region content was split into separate help topics. The lack of an explicit Secret regions column in IPI tabl e was an oversight. Previous to 4.10, the Government regions row served to indicate support for both the GovCloud and Top Secret regions.

OKD preview
Supported installation methods for different platforms

OCP preview
Supported installation methods for different platforms

[1] #40786
[2] #41149

@netlify
Copy link

netlify bot commented Mar 16, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: b3c2e4f

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/62337029b457d30009b27b58

😎 Browse the preview: https://deploy-preview-43337--osdocs.netlify.app

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 16, 2022
@mjpytlak mjpytlak changed the title Fixed formatting for install support matrix in OKD Fixed formatting for install support matrix in OKD and added missing entries Mar 16, 2022
@vrutkovs
Copy link
Member

/retitle Bug 2064395: Fixed formatting for install support matrix in OKD and added missing entries

@openshift-ci openshift-ci bot changed the title Fixed formatting for install support matrix in OKD and added missing entries Bug 2064395: Fixed formatting for install support matrix in OKD and added missing entries Mar 18, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2022

@mjpytlak: This pull request references Bugzilla bug 2064395, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2064395: Fixed formatting for install support matrix in OKD and added missing entries

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 18, 2022
@vrutkovs
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2022

@vrutkovs: This pull request references Bugzilla bug 2064395, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yunjiang@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 18, 2022
@vrutkovs
Copy link
Member

LGTM, thanks!

@mjpytlak
Copy link
Contributor Author

@yunjiang29 Please take a quick look at the OCP preview link. Given the 4.10 work that separated the GovCloud and Top Secret Region content into two help topics, I added a Secret regions row for AWS.

@mjpytlak
Copy link
Contributor Author

@yunjiang29 Could you take a quick look at this? I would like to get the corrections published. Thanks in advance.

@yunjiang29
Copy link
Contributor

@mjpytlak LGTM, thanks

@tmalove
Copy link
Contributor

tmalove commented Mar 23, 2022

@mjpytlak LGTM

@lpettyjo lpettyjo self-requested a review March 23, 2022 13:36
@lpettyjo lpettyjo added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.10 branch/enterprise-4.11 labels Mar 23, 2022
@lpettyjo lpettyjo added this to the Next Release milestone Mar 23, 2022
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 23, 2022
@lpettyjo lpettyjo merged commit 88d8b27 into openshift:main Mar 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

@mjpytlak: Bugzilla bug 2064395 is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 2064395: Fixed formatting for install support matrix in OKD and added missing entries

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #43687

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #43688

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@lpettyjo: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.10 from head openshift-cherrypick-robot:cherry-pick-43337-to-enterprise-4.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.10 and openshift-cherrypick-robot:cherry-pick-43337-to-enterprise-4.10"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants