-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-3220: Updating Bare metal UPI installations for arm installations #41149
OSDOCS-3220: Updating Bare metal UPI installations for arm installations #41149
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 32b41ac 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/620a9d0804cb8600086d08ba 😎 Browse the preview: https://deploy-preview-41149--osdocs.netlify.app |
5f02d40
to
145c923
Compare
145c923
to
d6aa36e
Compare
728cdea
to
a679ace
Compare
a679ace
to
ef8ebaa
Compare
installing/installing-preparing.adoc
Outdated
@@ -234,7 +234,7 @@ endif::openshift-origin[] | |||
.User-provisioned infrastructure options | |||
|=== | |||
ifndef::openshift-origin[] | |||
||AWS |Azure |Azure Stack Hub |GCP |{rh-openstack} |{rh-openstack} on SR-IOV |RHV |Bare metal |vSphere |VMC |IBM Z |IBM Z with {op-system-base} KVM |IBM Power |Platform agnostic | |||
||AWS |Azure |Azure Stack Hub |GCP |{rh-openstack} |{rh-openstack} on SR-IOV |RHV |Bare metal (x86_64) |Bare metal (ARM) |vSphere |VMC |IBM Z |IBM Z with {op-system-base} KVM |IBM Power |Platform agnostic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we say x86_64, then arm64 (or) aarch64 looks better.
Changes looks like:
Bare metal (x86_64) |Bare metal (arm64)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats a good point! I remember I only used that interface because thats how it looked in the infrastructure provider. I'll change that up!
ef8ebaa
to
964ed12
Compare
As anticipated, we need to add the following information in the "Installing RHCOS by using PXE or iPXE booting"
An example of the
cc @jeffdyoung to double-check. |
@aleskandro my grub.cfg is the same. I thought RHCOS supported x86 + UEFI, like RHEL: Do you know if QE tests UEFI on x86? |
@aleskandro and I discussed adding a new bullet point for PXE UEFI in step six here:
|
lgtm |
964ed12
to
0e452b8
Compare
} | ||
---- | ||
<1> Specify the locations of the {op-system} files that you uploaded to your | ||
HTTP/TFTP server. The `kernal` parameter value is the location of the `kernal` file on your TFTP server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be kernel not kernal (my bad)
0e452b8
to
23d677d
Compare
👍 from devel |
@aleskandro Just made the changes and they can be viewed in the previews. |
23d677d
to
5813cf6
Compare
@@ -160,7 +160,7 @@ This configuration does not enable serial console access on machines with a grap | |||
==== | |||
|
|||
ifndef::only-pxe[] | |||
** For iPXE: | |||
** For iPXE (`x86_64` + `arm64`): | |||
+ | |||
---- | |||
kernel http://<HTTP_server>/rhcos-<version>-live-kernel-<architecture> initrd=main coreos.live.rootfs_url=http://<HTTP_server>/rhcos-<version>-live-rootfs.<architecture>.img coreos.inst.install_dev=/dev/sda coreos.inst.ignition_url=http://<HTTP_server>/bootstrap.ign <1> <2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kelbrown20, I'd add another note at the end of this paragraph (just under the graphic console one) like:
Note: To network boot the CoreOS kernel on aarch64 architecture by iPXE, you need to use a version of iPXE built with the IMAGE_GZIP
option enabled. See IMAGE_GZIP option in iPXE
cc: @jeffdyoung
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e7a8143
to
9b81bc2
Compare
👍 from devel.. good catch @aleskandro |
Just fixed up those changes in the PR and previews, thank you! Last look before I send it out for docs peer review? @jeffdyoung @aleskandro |
lgtm |
9b81bc2
to
a1a9cb3
Compare
endif::ibm-power[] | ||
ifdef::ibm-power[] | ||
link:https://mirror.openshift.com/pub/openshift-v4/ppc64le/dependencies/rhcos/[{op-system} image mirror] | ||
endif::ibm-power[] | ||
page. | ||
pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move "page." and "pages." into their respective conditionals? Since they now differ singular vs plural.
@@ -32,13 +32,20 @@ You can manually install `bootupd` by using the `bootctl` command-line tool. | |||
# bootupctl status | |||
---- | |||
+ | |||
.Example output | |||
.Example outputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this "Example output for x86_64" and then for the new block add "Example output for arm64"?
+ | ||
[NOTE] | ||
==== | ||
To network boot the CoreOS `kernel` on `arm64` architecture, you need to use a version of iPXE build with the `IMAGE_GZIP` option enabled. See link:https://ipxe.org/buildcfg/image_gzip[IMAGE_GZIP option in iPXE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Period at the end.
Maybe markup IMAGE_GZIP
.
a1a9cb3
to
32b41ac
Compare
/cherrypick enterprise-4.10 |
@adellape: #41149 failed to apply on top of branch "enterprise-4.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://issues.redhat.com/browse/OSDOCS-3220
For Versions 4.10+
Previews: