-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS#6669: Add OLM 1.0 arch/components #65963
Conversation
511aecf
to
4f09cc3
Compare
0676406
to
2a09c41
Compare
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/30420 |
4ccd705
to
72fced4
Compare
72cc804
to
b938783
Compare
62e0ebb
to
545ebf9
Compare
"name": "example-extension", | ||
"defaultChannel": "preview" | ||
} | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lack of the ----
between each JSON section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get opm validate
to validate with ----
in the file, unless you are referring to breaking up each section into separate AsciiDoc ----
code blocks. However, opm validate
does pass the full index.json
file as is (all JSON sections together with no separations).
} | ||
] | ||
} | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, here lack of the ---- between each JSON section.
Others /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really snazzy! A few suggestions for you but overall lookin good :)
operators/olm_v1/olmv1-installing-an-operator-from-a-catalog.adoc
Outdated
Show resolved
Hide resolved
"version": "v0.0.1" | ||
"version": "0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to drop the v
here because it was failing validation:
$ opm validate plainbundlecatalog
FATA[0000] error parsing bundle "example-extension.v0.0.1" version "v0.0.1": Invalid character(s) found in major number "v0"
Seems possibly related to operator-framework/operator-registry#932. Running:
$ opm version
Version: version.Version{OpmVersion:"v1.30.0-2-gb1374806", GitCommit:"b1374806", BuildDate:"2023-10-24T14:02:39Z", GoOs:"darwin", GoArch:"arm64"}
/cherrypick enterprise-4.14 |
@adellape: #65963 failed to apply on top of branch "enterprise-4.14":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://issues.redhat.com/browse/OSDOCS-6669
OCP 4.14
olmv1-about-purpose.adoc
module (content already reviewed previously)olmv1-about-target-versions.adoc
module from 4.14 OLM 1.0 Tech Preview procedures #66036 (re-used content already reviewed)olmv1-about-catalogs.adoc
andolmv1-red-hat-catalogs.adoc
modules from 4.14 OLM 1.0 Tech Preview procedures #66036 (re-used content already reviewed)Preview: https://65963--docspreview.netlify.app/openshift-enterprise/latest/operators/olm_v1/arch/olmv1-components.html