-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.14 OLM 1.0 Tech Preview procedures #66036
4.14 OLM 1.0 Tech Preview procedures #66036
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/29262 |
fab5877
to
43b3f35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes from the engineering read through.
fa7cc57
to
c91051b
Compare
@jianzhangbjz or @Xia-Zhao-rh PTAL. |
Hi @kuiwang02 , could you help review it? Thanks! |
/assign @Xia-Zhao-rh |
b4c086b
to
8c7c6e1
Compare
Hi, @michaelryanpeter LGTM, Thanks. |
31e0937
to
2620a54
Compare
/lgtm |
/label qe-approved |
/lgtm |
/label qe-approved |
/lgtm |
+ | ||
[source,terminal] | ||
---- | ||
$ oc get package <catalog_name>-<operator_name> -o yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the same as above, the package_name
is better than the operator_name
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed.
type: image | ||
image: | ||
ref: registry.redhat.io/redhat/certified-operator-index:v{product-version} | ||
---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we also need to list the marketplace
operators here, such as,
apiVersion: catalogd.operatorframework.io/v1alpha1
kind: Catalog
metadata:
name: redhat-marketplace
spec:
source:
type: image
image:
ref: registry.redhat.io/redhat/redhat-marketplace-index:v{product-version}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jianzhangbjz PTAL at @kevinrizza's comment here: #66036 (comment)
I believe that engineering's preference is to leave off the Marketplace catalog, since it is built by IBM and we have less control if something doesn't work with OLM 1.0 at this stage of development.
If you feel strongly that this should be included, I will open a new ticket and PR for us to discuss the issue. We have until Friday 10/27 for docs merge freeze, so we have a bit of time to discuss this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created issue OSDOCS-8299. After this PR merges, I will create a follow up PR with the Marketplace catalog, so that we can get the change published before Docs Merge Freeze on 10/27.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up Marketplace catalog PR: #66647
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks!
2620a54
to
996ed2c
Compare
New changes are detected. LGTM label has been removed. |
996ed2c
to
b72b4d9
Compare
/cherrypick enterprise-4.14 |
@michaelryanpeter: new pull request created: #66645 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.14
Issues:
Link to docs preview: Installing an Operator from a catalog
QE review:
Additional information: