Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreos-layering-configuring: Remove cliwrap from the example #77066

Merged
merged 1 commit into from
Jun 12, 2024
Merged

coreos-layering-configuring: Remove cliwrap from the example #77066

merged 1 commit into from
Jun 12, 2024

Conversation

jmarrero
Copy link
Member

@jmarrero jmarrero commented Jun 5, 2024 •
edited by jldohmann
Loading

Doc update for OCPBUGS-33483

Version(s):
4.16 and up

Issue:
OCPBUGS-33483

Link to docs preview:

https://77066--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/coreos-layering.html
QE review:

  • QE has approved this change.

Additional information:

This is required along with changes to rpm-ostree for OCP 4.16 and up, if the cliwrap is left in the docs users will encounter: https://issues.redhat.com/browse/OCPBUGS-30149

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2024
@ocpdocs-previewbot
Copy link

🤖 Wed Jun 05 18:14:28 - Prow CI generated the docs preview:

https://77066--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/coreos-layering.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 5, 2024

@jmarrero: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jlebon
jlebon approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I guess let's wait until OCPBUGS-33483 is VERIFIED to merge it.

@jmarrero
Copy link
Member Author

OCPBUGS-33483 has been VERIFIED.

jldohmann
jldohmann approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening this Joseph! LGTM

@jldohmann jldohmann added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.16 labels Jun 12, 2024
@jldohmann jldohmann added this to the Planned for 4.16 GA milestone Jun 12, 2024
@jldohmann
Copy link
Contributor

@mike-nguyen can you PTAL at this docs PR for QE ack? thank you!

HuijingHei
HuijingHei approved these changes Jun 12, 2024
View reviewed changes
Copy link

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
@jldohmann jldohmann merged commit bc01148 into openshift:main Jun 12, 2024
3 checks passed
@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #77382

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 12, 2024
Merged
@jlebon jlebon mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@jldohmann jldohmann jldohmann approved these changes

@HuijingHei HuijingHei HuijingHei approved these changes

Assignees

@HuijingHei HuijingHei

Labels
branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.16 GA
Development

Successfully merging this pull request may close these issues.
6 participants
@jmarrero @ocpdocs-previewbot @jldohmann @openshift-cherrypick-robot @jlebon @HuijingHei