Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not disable catalog filtering input when only one item is available #427

Closed
jeff-phillips-18 opened this issue Sep 12, 2017 · 3 comments
Closed

Do not disable catalog filtering input when only one item is available #427

jeff-phillips-18 opened this issue Sep 12, 2017 · 3 comments
Assignees
@jeff-phillips-18
Labels
area/usability priority/P3
Milestone
3.7.0

Comments

@jeff-phillips-18
Copy link
Member

Disabling when there is only one item is inconsistent with the patternfly pattern and is not intuitive since there is no real need for filtering when there are 2 or 3 or 4 items either.
@jeff-phillips-18 jeff-phillips-18 self-assigned this Sep 12, 2017
@jeff-phillips-18 jeff-phillips-18 mentioned this issue Sep 12, 2017
Merged
@spadgett spadgett added this to the 3.7.0 milestone Sep 13, 2017
@jeff-phillips-18
Copy link
Member Author

Filtering has changed and this issue is no longer applicable.

@spadgett
Copy link
Member

@jeff-phillips-18 It is still disabled as far as I can tell, although not a huge issue. (Hard to tell in the screenshot, but the controls are disabled.)

openshift web console 2017-09-19 11-38-04

@jeff-phillips-18
Copy link
Member Author

Ah, ok. I just saw that the original filter box was gonzo. Reopening.

jeff-phillips-18 added a commit to jeff-phillips-18/origin-web-catalog that referenced this issue Sep 19, 2017
@jeff-phillips-18
Do not disable filter components when only 1 item is available
a463f69 
Fixes openshift#427
@jeff-phillips-18 jeff-phillips-18 mentioned this issue Sep 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
area/usability priority/P3
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@spadgett @jeff-phillips-18