Bug 1490688: Do not disable filter input for importing a template from a project #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
approved these changes
Sep 12, 2017
|
[merge][severity: blocker] |
|
@jeff-phillips-18 @beanh66 Do we want to make the same change on the landing page for consistency? |
|
Evaluated for origin web console merge up to b35c0df |
|
@spadgett I would agree with that. I will open an issue for it. |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/170/) (Base Commit: 9476f92) (PR Branch Commit: b35c0df) (Extended Tests: blocker) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1490688
The real issue in the bug is that the input should have been disabled to begin with since there is only 1 template available. The input is not yet available so it was not being disabled. No real need to disable the input at all. It was only disabled when there is only one item but that is kind of pointless since I don't really need to filter with 2 or 3 or 4... (confirmed with @beanh66)