Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing catalog wizard #438

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Fixing catalog wizard #438

merged 1 commit into from
Sep 18, 2017

Conversation

rhamilto
Copy link
Member

Supports openshift/origin-web-console#2087

Changes to PatternFly's wizard resulted in no content appearing in our catalog overlay modals. This PR resolves that issue. Given #413 is to change the layout of the wizard to a single column at all times, I intend to further refine the display and possibly eliminate the use of 100vh because of issues with mobile browsers' interpretation of vh units as part of #413.

bower.json Outdated
@@ -37,7 +37,7 @@
"angular-bootstrap": "0.14.3",
"angular-patternfly": ">=4.7.1 <5.0.0",
"angular-schema-form": "^0.8.13",
"patternfly": "~3.26.1",
"patternfly": ">=3.27.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

"patternfly": ">=3.27.2 <4.0.0"

@@ -47,7 +47,6 @@
"ace-builds": "1.2.2",
"angular-extension-registry": "1.2.6",
"angular-inview": "1.5.7",
"angular-key-value-editor": "3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants