Fixing catalog wizard #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
approved these changes
Sep 18, 2017
spadgett
reviewed
Sep 18, 2017
bower.json
Outdated
| @@ -37,7 +37,7 @@ | |||
| "angular-bootstrap": "0.14.3", | |||
| "angular-patternfly": ">=4.7.1 <5.0.0", | |||
| "angular-schema-form": "^0.8.13", | |||
| "patternfly": "~3.26.1", | |||
| "patternfly": ">=3.27.2", | |||
There was a problem hiding this comment.
Maybe
"patternfly": ">=3.27.2 <4.0.0"| @@ -47,7 +47,6 @@ | |||
| "ace-builds": "1.2.2", | |||
| "angular-extension-registry": "1.2.6", | |||
| "angular-inview": "1.5.7", | |||
| "angular-key-value-editor": "3.0.0", | |||
spadgett
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports openshift/origin-web-console#2087
Changes to PatternFly's wizard resulted in no content appearing in our catalog overlay modals. This PR resolves that issue. Given #413 is to change the layout of the wizard to a single column at all times, I intend to further refine the display and possibly eliminate the use of 100vh because of issues with mobile browsers' interpretation of vh units as part of #413.