Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot upgrade angular-patternfly as it breaks the modal #2087

Closed
benjaminapetersen opened this issue Sep 15, 2017 · 4 comments
Closed

Cannot upgrade angular-patternfly as it breaks the modal #2087

benjaminapetersen opened this issue Sep 15, 2017 · 4 comments
Assignees
@rhamilto
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@benjaminapetersen
Copy link
Contributor

Attempted to update angular-patternfly to latest 4.9.1 to pickup the accessibilty updates for modal, but the modals break:

screen shot 2017-09-15 at 11 41 19 am

Not sure what happened there. Works fine on master, only change is "angular-patternfly": "4.9.1", in bower.json.

@spadgett @jeff-phillips-18
@benjaminapetersen benjaminapetersen mentioned this issue Sep 15, 2017
Closed
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Sep 15, 2017
@spadgett
Copy link
Member

You need the latest Patternfly, too, but I still see the problem when bumping Patternfly.

@benjaminapetersen
Copy link
Contributor Author

lol @rhamilto ping as well, didn't realize this is what you all were talking about in the irc chat.

@rhamilto rhamilto mentioned this issue Sep 18, 2017
Merged
@spadgett
Copy link
Member

Should be fixed by openshift/origin-web-catalog#438 when we bump catalog

@spadgett
Copy link
Member

Fixed by #2103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhamilto rhamilto

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjaminapetersen @rhamilto @spadgett