Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping dependency version in bower.json #2103

Merged

Conversation

benjaminapetersen
Copy link
Contributor

@benjaminapetersen benjaminapetersen commented Sep 18, 2017

Currently only bumping common
@sg00dwin's PR's still open in patternfly, so not yet included:

Do we want to wait for these items? Also have some resolution issues
between console/common.

@spadgett @sg00dwin

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Sep 18, 2017

Haven't built yet due to:

Unable to find a suitable version for kubernetes-label-selector, please choose one by typing one of the numbers below:
    1) kubernetes-label-selector#2.0.0 which resolved to 2.0.0 and is required by origin-web-console
    2) kubernetes-label-selector#~2.1.1 which resolved to 2.1.1 and is required by origin-web-common#0.0.57

Can we open this up to accept a range with one of the repos, prob common? Good to avoid a resolution.

@spadgett
Copy link
Member

We should update that dependency in console.

@benjaminapetersen I'm working on a catalog release so we can bump everything at once.

@benjaminapetersen
Copy link
Contributor Author

@spadgett sounds good

@spadgett
Copy link
Member

@spadgett
Copy link
Member

origin-web-catalog 0.0.46 published

@benjaminapetersen
Copy link
Contributor Author

Updated.

@benjaminapetersen
Copy link
Contributor Author

patternfly and angular-patternfly bumped as well.

@spadgett
Copy link
Member

Need to bump kubernetes-label-selector to 2.1.1

@spadgett
Copy link
Member

Remove patternfly resolution. I don't think it's needed anymore.

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Sep 18, 2017

Great, will do. Slowly whittling them down...

Also removing:

gruntbower bootstrap-select extra-resolution Unnecessary resolution: bootstrap-select#^1.10.0

@spadgett
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 6e43fb3

@openshift-bot openshift-bot merged commit d06b7c0 into openshift:master Sep 18, 2017
@openshift-bot
Copy link

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/218/) (Base Commit: b4196ee) (PR Branch Commit: 6e43fb3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants