Viewers see empty env var input rather than message when no env vars

[spadgett]

I thought this was a little odd. I logged in as a user with view role in the project. Instead of seeing a message saying there are no env vars, I see two readonly inputs.

[benjaminapetersen]

hmm. yeah that is weird. ill take a look

[benjaminapetersen]

I can reproduce this. So Its probably something we need to either 1. put inside KVE, or 2. update all the templates where KVE appears with an ng-if & an alt message. @rhamilto

Do we have a preference either way? I lean towards the ng-if since we are not limited to just env vars.

[spadgett]

For replication controllers we do this:

https://github.com/spadgett/origin-web-console/blob/6c0257867c68da506b49a3e42fd6476e035c2863/app/views/browse/replica-set.html#L79

[rhamilto]

Do we have a preference either way? I lean towards the ng-if since we are not limited to just env vars.

Agreed. No point in showing the KVE if there is nothing to display (i.e., read only env vars).

[benjaminapetersen]

Ok, I can find 10 instances of KVE in readonly mode, I believe each one should have a message like this, but will check them over.

• browse/build.html
• browse/deployment.html
• browse/build-config.html (partial, see The BuildConfig environment tab is awkward for a user with view permissions #1969)
• browse/deployment-config.html
• browse/pod.html
• browse/replica-set.html
• browse/stateful-set.html
• create/fromimage.html (not relevant issue for the create flow)
• directives/label-editor.html
  • directives/deploy-image.html
  • directives/process-template.html
  • edit/autoscaler.html
• directives/next-steps.html (not relevant)

(branch: bpeterse/kve-hide-empty)