Ensure kve does not render on browser builds if no envs to show #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Aug 29, 2017
app/views/browse/build.html
Outdated
| @@ -104,6 +104,7 @@ <h1 class="contains-actions"> | |||
| Environment variables can be edited on the <a ng-href="{{build | configURLForResource}}?tab=environment">build configuration</a>. | |||
| </p> | |||
| <key-value-editor | |||
| ng-if="(build | buildStrategy).env" | |||
There was a problem hiding this comment.
Should be checking size to catch empty arrays?
ng-if="(build | buildStrategy).env | size"
benjaminapetersen
force-pushed
the
bpeterse/hide-kve-on-build-if-no-envs
branch
from
ea373e7
to
0c06867
Compare
app/views/browse/build.html
Outdated
| @@ -104,6 +104,7 @@ <h1 class="contains-actions"> | |||
| Environment variables can be edited on the <a ng-href="{{build | configURLForResource}}?tab=environment">build configuration</a>. | |||
| </p> | |||
| <key-value-editor | |||
There was a problem hiding this comment.
@spadgett thx, updated
openshift-bot
added
the
needs-rebase
|
Hey @benjaminapetersen I think if you rebase this, we should be set to merge |
benjaminapetersen
force-pushed
the
bpeterse/hide-kve-on-build-if-no-envs
branch
from
0c06867
to
6c73175
Compare
|
thanks @spadgett , rebased. |
|
[merge][severity: bug] |
|
Evaluated for origin web console merge up to 6c73175 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/193/) (Base Commit: f446b03) (PR Branch Commit: 6c73175) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1438
There is already a good message
The build strategy had no environment variables defined., this just ensures thekvedoesn't render at all (rather than renders but is empty).@spadgett