Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The BuildConfig environment tab is awkward for a user with view permissions #1969

Closed
benjaminapetersen opened this issue Aug 25, 2017 · 2 comments
Assignees
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3

Comments

@benjaminapetersen
Copy link
Contributor

For a non-admin user, this experience is a bit strange:

screen shot 2017-08-25 at 4 21 55 pm

If you then click the link to show hidden vars:

screen shot 2017-08-25 at 4 22 52 pm

My guess that we hide the readonly empty KVE, and update the message to remove the word additional if ng-if="'buildconfigs' | canI : 'update'" is false, but still allow the user to click to see the expanded view.

related to #1438

@spadgett

@spadgett
Copy link
Member

@benjaminapetersen Is this fixed by #1970?

@jwforres
Copy link
Member

Just noting this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Development

No branches or pull requests

3 participants