Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to next steps/results messaging #2217

Closed
2 of 4 tasks
rhamilto opened this issue Oct 5, 2017 · 6 comments
Closed
2 of 4 tasks

Enhancements to next steps/results messaging #2217

rhamilto opened this issue Oct 5, 2017 · 6 comments
Assignees
@spadgett
Labels
area/usability lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2

Comments

@rhamilto
Copy link
Member

rhamilto commented Oct 5, 2017 •
edited by spadgett

In #2184, we didn't get to a few items and punted on them. This issue is to track them so we tackle them in the near future.

  • Display webhook info when appropriate inside wizard results (currently only shows on standalone next steps)
  • Show proper type of imported item in import wizard results (non-templates are generically called "YAML / JSON"). [sgoodwin] And resolve bug where results-status-unknown message displays instead of results-status success when importing statefulset-hello.yaml.
    screen shot 2017-10-17 at 4 21 14 pm
  • Improve display of provision call failure message. Upstream message formatting improved.
    screen shot 2017-10-02 at 3 25 21 pm
    screen shot 2017-10-02 at 3 29 01 pm
    screen shot 2017-10-02 at 3 29 14 pm
    screen shot 2017-10-03 at 11 27 16 am
  • Add appropriate actions when failure occurs
@spadgett spadgett added this to the 3.7.0 milestone Oct 10, 2017
@spadgett spadgett mentioned this issue Oct 18, 2017
Closed
@jhadvig
Copy link
Member

jhadvig commented Oct 19, 2017

The Improve display of provision call failure message item is blocked on kubernetes-retired/service-catalog#1435
@rhamilto @spadgett FYI

@spadgett
Copy link
Member

I'm looking at the import YAML message now. We have a separate bug for it from QE:

https://bugzilla.redhat.com/show_bug.cgi?id=1505281

This was referenced Oct 30, 2017
Merged
Merged
openshift-merge-robot added a commit that referenced this issue Oct 31, 2017
@openshift-merge-robot
Merge pull request #2401 from spadgett/format-instance-status-messages
0beaf62 
Automatic merge from submit-queue.

Preserve newlines in broker status messages

Preserve newlines in service instance status messages on the overview
and the provisioned service page. Truncate long message when displayed
in a tooltip.

See #2217

![screen shot 2017-10-30 at 3 44 27 pm](https://user-images.githubusercontent.com/1167259/32192505-bb62ecc8-bd8a-11e7-9531-385f538c3f52.png)

![screen shot 2017-10-30 at 4 11 12 pm](https://user-images.githubusercontent.com/1167259/32193223-fd560b4a-bd8c-11e7-8ae9-1cc37575fcdf.png)

![screen shot 2017-10-30 at 3 46 30 pm](https://user-images.githubusercontent.com/1167259/32192518-c6f75948-bd8a-11e7-8f97-f22e0a5eb258.png)
@spadgett spadgett mentioned this issue Nov 1, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Nov 1, 2017
@openshift-merge-robot
Merge pull request #2426 from spadgett/fix-import-yaml-msg
84d6d04 
Automatic merge from submit-queue.

Bug 1505281 - Improve import YAML results message

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505281
See also #2217 

List:

![openshift web console 2017-11-01 13-30-16](https://user-images.githubusercontent.com/1167259/32288915-bafbb06c-bf0b-11e7-9322-50c6b252f44c.png)

Single resource:

![openshift web console 2017-11-01 13-46-08](https://user-images.githubusercontent.com/1167259/32288894-b2e9ef10-bf0b-11e7-816b-bce315c1b036.png)

/kind bug

cc @rhamilto @jwforres
@spadgett spadgett removed this from the 3.7.0 milestone Feb 23, 2018
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 17, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
area/usability lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rhamilto @spadgett @jhadvig @openshift-bot @openshift-ci-robot