-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1505281 - Improve import YAML results message #2426
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
spadgett:fix-import-yaml-msg
Nov 1, 2017
Merged
Bug 1505281 - Improve import YAML results message #2426
openshift-merge-robot
merged 1 commit into
openshift:master
from
spadgett:fix-import-yaml-msg
Nov 1, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
kind/bug
Categorizes issue or PR as related to a bug.
labels
Nov 1, 2017
Still testing the different scenarios |
openshift-ci-robot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Nov 1, 2017
jwforres
approved these changes
Nov 1, 2017
lgtm but |
openshift-ci-robot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Nov 1, 2017
guess i could've actually, still getting use to these fancy new options |
Found a bug (#2427), but I think it's unrelated to this change. |
spadgett
force-pushed
the
fix-import-yaml-msg
branch
from
November 1, 2017 18:23
8f54306
to
886aeeb
Compare
openshift-ci-robot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 1, 2017
spadgett
force-pushed
the
fix-import-yaml-msg
branch
from
November 1, 2017 18:35
886aeeb
to
136dd4b
Compare
spadgett
changed the title
[WIP] Bug 1505281 - Improve import YAML results message
Bug 1505281 - Improve import YAML results message
Nov 1, 2017
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Nov 1, 2017
Rebased and rebuilt. Removing WIP. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Nov 1, 2017
Reproduced #2427 without these changes. |
Adding back the lgtm label since the last changes were a rebase only |
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505281
See also #2217
List:
Single resource:
/kind bug
cc @rhamilto @jwforres