Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canI checks for route custom hosts #1935

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Add canI checks for route custom hosts #1935

merged 1 commit into from
Aug 15, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Aug 15, 2017 •
edited

@spadgett
Copy link
Member Author

This adds canI checks for custom hosts when creating routes (create verb on routes/custom-host) and editing routes (update verb on routes/custom-host).

@smarterclayton confirming all certificate fields (certificate, key, CA cert, destination CA cert) should be readonly when the canI checks returns false.

@spadgett
Copy link
Member Author

[test]

@spadgett
Add canI checks for route custom hosts
6cc4254 
Disable hostname and certificate inputs if the user doesn't have
`canI` check returns false for `routes/custom-host`.
@spadgett
Copy link
Member Author

Opened #1937 for the test flake

[test]

@openshift-bot
Copy link

Evaluated for origin web console test up to 6cc4254

@openshift-bot
Copy link

Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/43/) (Base Commit: 56c925a) (PR Branch Commit: 6cc4254)

jeff-phillips-18
jeff-phillips-18 approved these changes Aug 15, 2017
View reviewed changes
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benjaminapetersen
benjaminapetersen approved these changes Aug 15, 2017
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still digesting the original issue details, but changes look good to me!

@spadgett
Copy link
Member Author

[merge][severity:bug]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 6cc4254

@openshift-bot
Copy link

openshift-bot commented Aug 15, 2017 •
edited

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/73/) (Base Commit: 6cd2686) (PR Branch Commit: 6cc4254) (Extended Tests: bug)

@openshift-bot openshift-bot merged commit e89bb67 into openshift:master Aug 15, 2017
@spadgett spadgett deleted the canI-custom-hosts branch August 15, 2017 16:06
@ValentinFunk
Copy link

May I ask why it's not OK to update certs? Having a bit of trouble with this in the dev preview where i can't get letsencrypt working as the controller needs to patch the routes with the renewed certs

@spadgett spadgett mentioned this pull request Sep 18, 2017
Merged
@spadgett spadgett mentioned this pull request Jan 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spadgett @openshift-bot @ValentinFunk @benjaminapetersen @jeff-phillips-18