Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File path input should always be readonly #2101

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

spadgett
Copy link
Member

The text input for uploading files should always be readonly since you can't type a file name. You have to use the browse button or drag and drop.

Regression introduced in #1935

The text input for uploading files should always be readonly since you
can't type a file name. You have to use the browse button or drag and drop.
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spadgett
Copy link
Member Author

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 5104713

@openshift-bot
Copy link

openshift-bot commented Sep 18, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/212/) (Base Commit: 44d587b) (PR Branch Commit: 5104713)

@openshift-bot openshift-bot merged commit 181d896 into openshift:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants