Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stage] File path input should always be readonly #2102

Closed
wants to merge 1 commit into from

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Sep 18, 2017

The text input for uploading files should always be readonly since you can't type a file name. You have to use the browse button or drag and drop.

Backporting #2101 to the stage branch.

The text input for uploading files should always be readonly since you
can't type a file name. You have to use the browse button or drag and drop.
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spadgett
Copy link
Member Author

[merge]

@spadgett
Copy link
Member Author

[test]

@spadgett
Copy link
Member Author

Opened flake #2105

[test]

@openshift-bot
Copy link

Evaluated for origin web console test up to 031d431

@spadgett
Copy link
Member Author

Stage FORWARD PARAMETERS TO THE REMOTE HOST [00h 00m 00s] failed.

[merge]

@openshift-bot
Copy link

Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/231/) (Base Commit: 0200cf1) (PR Branch Commit: 031d431)

@spadgett
Copy link
Member Author

FINISHED STAGE: FAILURE: FORWARD PARAMETERS TO THE REMOTE HOST

[merge]

@spadgett
Copy link
Member Author

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 031d431

@openshift-bot
Copy link

Origin Web Console Merge Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/230/) (Base Commit: 0200cf1) (PR Branch Commit: 031d431)

@spadgett spadgett closed this Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants