-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stage] File path input should always be readonly #2102
Conversation
The text input for uploading files should always be readonly since you can't type a file name. You have to use the browse button or drag and drop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[merge] |
[test] |
Opened flake #2105 [test] |
Evaluated for origin web console test up to 031d431 |
[merge] |
Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/231/) (Base Commit: 0200cf1) (PR Branch Commit: 031d431) |
[merge] |
[merge] |
Evaluated for origin web console merge up to 031d431 |
Origin Web Console Merge Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/230/) (Base Commit: 0200cf1) (PR Branch Commit: 031d431) |
The text input for uploading files should always be readonly since you can't type a file name. You have to use the browse button or drag and drop.
Backporting #2101 to the stage branch.