Remove "tasks" message from overview #2205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wizard results step and next step pages show the tasks result. It's not needed on the overview.
jeff-phillips-18
approved these changes
Oct 3, 2017
rhamilto
approved these changes
Oct 3, 2017
|
Do we want to go ahead and remove the tasks directive since it's no longer being used? https://github.com/openshift/origin-web-console/blob/master/app/views/directives/next-steps.html#L54-L83 is duplication of some of the task directive's markup (they differ a bit). |
I've removed the tasks directive in #2209 |
|
Closing in favor of #2209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wizard results step and next step pages show the tasks result. It's not needed on the overview and results in multiple different alert styles.
I removed one of these in #2184, but I missed the other:
https://github.com/openshift/origin-web-console/pull/2184/files#diff-361579fdd045e14f6dc3e106d5feb425L5