Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving display of results status messages and removing orphaned ta… #2209

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Improving display of results status messages and removing orphaned ta… #2209

merged 1 commit into from
Oct 3, 2017

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 3, 2017 •
edited
Loading

…sks directive

Requires catalog and common releases

screen shot 2017-10-02 at 3 11 14 pm

screen shot 2017-10-02 at 3 13 13 pm

![screen shot 2017-10-03 at 12 12 36 pm](https://user-images.githubusercontent.com/895728/31147557-381f465a-a858-11e7-9aa0-812b9593bfae.PNG) ![screen shot 2017-10-03 at 12 12 52 pm](https://user-images.githubusercontent.com/895728/31147558-3820540a-a858-11e7-957a-772185520910.PNG) ![Uploading Screen Shot 2017-10-03 at 12.13.10 PM.PNG…]() ![screen shot 2017-10-03 at 12 14 45 pm](https://user-images.githubusercontent.com/895728/31147556-381e49f8-a858-11e7-8a01-d0497fe3bbfb.PNG)

@rhamilto rhamilto requested a review from spadgett October 3, 2017 20:21
@rhamilto rhamilto mentioned this pull request Oct 3, 2017
Closed
@rhamilto rhamilto changed the title [WIP] Improving display of results status messages and removing orphaned ta… Improving display of results status messages and removing orphaned ta… Oct 3, 2017
@spadgett
Copy link
Member

spadgett commented Oct 3, 2017

Dist is correct and unit tests passing:

Chrome 61.0.3163 (Mac OS X 10.13.0): Executed 113 of 113 SUCCESS (1.636 secs / 1.308 secs)
Firefox 55.0.0 (Mac OS X 10.13.0): Executed 113 of 113 SUCCESS (3.902 secs / 2.839 secs)

@spadgett spadgett merged commit 19ffee3 into openshift:master Oct 3, 2017
@rhamilto rhamilto deleted the results-styling branch October 4, 2017 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhamilto @spadgett