Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triggered panic during regular update #1351

Closed
smarterclayton opened this issue Mar 18, 2015 · 4 comments
Closed

Triggered panic during regular update #1351

smarterclayton opened this issue Mar 18, 2015 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@smarterclayton
Copy link
Contributor

When updating this object:

apiVersion: v1beta1
creationTimestamp: null
desiredState:
  manifest:
    containers:
    - capabilities: {}
      image: centos:centos7
      command: ["/usr/bin/sleep"]
      imagePullPolicy: ""
      name: test
      resources: {}
    id: ""
    restartPolicy: {}
    version: v1beta2
    volumes: null
id: test
kind: Pod
labels:
  run-container: test

to

apiVersion: v1beta1
creationTimestamp: null
desiredState:
  manifest:
    containers:
    - capabilities: {}
      image: centos:centos7
      command: ["/usr/bin/sleep", "1"]
      imagePullPolicy: ""
      name: test
      resources: {}
    id: ""
    restartPolicy: {}
    version: v1beta2
    volumes: null
id: test
kind: Pod
labels:
  run-container: test

goroutine 6371 [running]:
runtime.panic(0xfcbe80, 0xc209f2d3f0)
    /usr/lib/golang/src/pkg/runtime/panic.c:279 +0xf5
reflect.Value.Index(0xf91140, 0xc2088d5220, 0x0, 0x176, 0x1, 0x0, 0x0, 0x0, 0x0)
    /usr/lib/golang/src/pkg/reflect/value.go:1008 +0x316
github.com/GoogleCloudPlatform/kubernetes/pkg/conversion.Equalities.deepValueEqual(0xc2080a0db0, 0xf91140, 0xc209c12140, 0x0, 0x176, 0xf91140, 0xc2088d5220, 0x0, 0x176, 0xc20a0bd9b0, ...)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/conversion/deep_equal.go:167 +0x1882
github.com/GoogleCloudPlatform/kubernetes/pkg/conversion.Equalities.deepValueEqual(0xc2080a0db0, 0x13c8ec0, 0xc209c12120, 0x0, 0x196, 0x13c8ec0, 0xc2088d5200, 0x0, 0x196, 0xc20a0bd9b0, ...)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/conversion/deep_equal.go:181 +0x1b36
github.com/GoogleCloudPlatform/kubernetes/pkg/conversion.Equalities.deepValueEqual(0xc2080a0db0, 0xf870c0, 0xc209be10b8, 0x0, 0x172, 0xf870c0, 0xc209be1128, 0x0, 0x172, 0xc20a0bd9b0, ...)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/conversion/deep_equal.go:167 +0x192c
github.com/GoogleCloudPlatform/kubernetes/pkg/conversion.Equalities.deepValueEqual(0xc2080a0db0, 0x1358f80, 0xc209be10a0, 0x0, 0x192, 0x1358f80, 0xc209be1110, 0x0, 0x192, 0xc20a0bd9b0, ...)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/conversion/deep_equal.go:181 +0x1b36
github.com/GoogleCloudPlatform/kubernetes/pkg/conversion.Equalities.DeepEqual(0xc2080a0db0, 0x1358f80, 0xc209be10a0, 0x1358f80, 0xc209be1110, 0xc209c12120)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/conversion/deep_equal.go:234 +0x255
github.com/GoogleCloudPlatform/kubernetes/pkg/api/validation.ValidatePodUpdate(0xc20a146340, 0xc20a146680, 0x0, 0x0, 0x0)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/api/validation/validation.go:650 +0x79f
github.com/GoogleCloudPlatform/kubernetes/pkg/registry/pod.podStrategy.ValidateUpdate(0x7fc09be2e240, 0xc20804a0e0, 0x7fc09be2b9d0, 0x0, 0x7fc09be2b9f8, 0xc20a146340, 0x7fc09be2b9f8, 0xc20a146680, 0x0, 0x0, ...)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/registry/pod/rest.go:71 +0xa3
github.com/GoogleCloudPlatform/kubernetes/pkg/registry/pod.(*podStrategy).ValidateUpdate(0xc208223da0, 0x7fc09be2b9f8, 0xc20a146340, 0x7fc09be2b9f8, 0xc20a146680, 0x0, 0x0, 0x0)
    <autogenerated>:38 +0xe5
github.com/GoogleCloudPlatform/kubernetes/pkg/api/rest.BeforeUpdate(0x7fc09be4b548, 0xc208223da0, 0x7fc09be4ae50, 0xc20a5a6210, 0x7fc09be2b9f8, 0xc20a146340, 0x7fc09be2b9f8, 0xc20a146680, 0x0, 0x0)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/api/rest/update.go:55 +0x28d
github.com/GoogleCloudPlatform/kubernetes/pkg/registry/generic/etcd.func·001(0x7fc09be2b9f8, 0xc20a146680, 0x0, 0x0, 0x0, 0x0)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/registry/generic/etcd/etcd.go:249 +0x313
github.com/GoogleCloudPlatform/kubernetes/pkg/tools.(*EtcdHelper).AtomicUpdate(0xc2083e4148, 0xc20a11f000, 0x1b, 0x7fc09be2b9f8, 0xc20a1464e0, 0x1, 0xc20a097e28, 0x0, 0x0)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/tools/etcd_tools.go:389 +0x2d9
github.com/GoogleCloudPlatform/kubernetes/pkg/registry/generic/etcd.(*Etcd).Update(0xc2083e40c0, 0x7fc09be4ae50, 0xc20a5a6210, 0x7fc09be2b9f8, 0xc20a146340, 0x0, 0x0, 0x7fc081a6ef80, 0x0, 0x0)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/registry/generic/etcd/etcd.go:254 +0x284
github.com/GoogleCloudPlatform/kubernetes/pkg/registry/pod/etcd.(*REST).Update(0xc20804ac90, 0x7fc09be4ae50, 0xc20a5a6210, 0x7fc09be2b9f8, 0xc20a146340, 0x0, 0x0, 0x41df2c, 0x0, 0x0)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/registry/pod/etcd/etcd.go:113 +0x87
github.com/GoogleCloudPlatform/kubernetes/pkg/apiserver.func·021(0x0, 0x0, 0x0, 0x0)
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/apiserver/resthandler.go:224 +0x91
github.com/GoogleCloudPlatform/kubernetes/pkg/apiserver.func·025()
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/apiserver/resthandler.go:311 +0x37
created by github.com/GoogleCloudPlatform/kubernetes/pkg/apiserver.finishRequest
    /data/src/github.com/openshift/origin/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/apiserver/resthandler.go:316 +0x156

Also, the panic should have been recovered.
@soltysh
Copy link
Contributor

soltysh commented Mar 18, 2015

Shouldn't that go upstream, since it's Pod related or were you using some OpenShift specific tool for that?

@smarterclayton
Copy link
Contributor Author

Someone should try to repro upstream, yes

On Mar 18, 2015, at 4:58 PM, Maciej Szulik notifications@github.com wrote:

Shouldn't that go upstream, since it's Pod related or were you using some OpenShift specific tool for that?

—
Reply to this email directly or view it on GitHub.

@danmcp
Copy link

danmcp commented May 11, 2015

Still an issue?

@danmcp danmcp added component/master kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels May 11, 2015
@smarterclayton
Copy link
Contributor Author

Probably, no one has looked at it

@danmcp danmcp closed this as completed May 15, 2015
jboyd01 pushed a commit to jboyd01/origin that referenced this issue Oct 17, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
f5e4c52 
…service-catalog/' changes from 3aacfedec6..aa27078754

aa27078754 origin build: add origin tooling
bcf37fd 0.1.0-rc2 chart updates (openshift#1410)
4ab0a0a add back 'Processing' message for instance deletion (openshift#1332)
0ecbcb1 Update logs for Cluster service plans. (openshift#1389)
8b491ef Fix a quoting nit (openshift#1400)
63685e4 add orphan mitigation-specific conditions for instances (openshift#1378)
adee662 Updated missed fields in service and plan specs (openshift#1406)
2095919 Handle default plan setting when using k8s names (openshift#1405)
607ba66 Document rbacEnable. (openshift#1404)
268294e Adding rbac definition for v1 api endpoint. (openshift#1284)
103288d differentiate between failed updates and provisions during deletion (openshift#1383)
eba8ba4 enable API aggregation and Service Catalog RBAC on Jenkins (openshift#1333)
5a93315 Validate relistDuration is non-negative (openshift#1395)
e279d21 Fix log messages for secrets (openshift#1385)
87fa8c9 fix status update when starting orphan mitigation (openshift#1372)
11f18f3 Switch to wget for integration apiserver checks (openshift#1384)
8c44a7d update OSB client to 2.13 (openshift#1392)
e64bbd1 default plan admission controller: filter list of service plans/service classes by the class name (openshift#1351)
6648c0e Check field names. Fix issue 1291 (openshift#1379)
5319841 update comment for instance generation check (openshift#1382)
7d5823f remove internal poll method (openshift#1381)
07d3068 Rework the logging for controller_instance. (openshift#1371)
5f4ca01 address PR comment as a followup (openshift#1380)
485d5e6 Add support for specifying plan using K8S names. (openshift#1377)
662bba8 Log number of secret keys created for binding credential (openshift#1375)
8ad6a31 Move controller constants into correct files (openshift#1373)
7bd66dd Adding type to log. (openshift#1339)
1ce5c4d Remove k8s/k8s dependency (openshift#1355)
b458323 Adding log formatting for BindingController. (openshift#1352)
275eb11 rename test variables to be consistent (openshift#1315)
ffd6b8b travis: skip cleanup before deploy (openshift#1368)
d5ecc04 fix travis tag checker (openshift#1365)
2cae0ee Minor updates to README (openshift#1360)
REVERT: 3aacfedec6 carry: Set external plan name for service-catalog walkthrough
REVERT: 3ec9e5b07a origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: aa2707875461dd51be3731b1d94b5cfc3b9a3976
jpeeler pushed a commit to jpeeler/origin that referenced this issue Feb 1, 2018
@pmorie
default plan admission controller: filter list of service plans/servi…
e64bbd1 
…ce classes by the class name (openshift#1351)

* filter list of service plans/service classes by the specified service class name

* add success test determining default plan when there are multiple plans but each from a different classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danmcp @soltysh @smarterclayton