Auto provision image stream #1404
Conversation
|
@smarterclayton interested in doing this? |
|
Yes if user has permission. |
|
If a project/namespace doesn't exist yet, should this create it (assuming the user has permissions to do so)? I'm thinking no... |
|
No
|
|
What's the status of this? |
|
I'll have it in once I finish reviewing Ravi's v2 auth work. That's a prerequisite. Sent from my iPhone
|
ncdc
force-pushed
the
auto-provision-image-repo
branch
from
23aa0d9
to
a78df0c
Compare
ncdc
changed the title
|
@smarterclayton @liggitt I'd like to add a test for this to e2e, but I need an oauth token and I'm not sure how to automate requesting one, as |
|
[test] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1755/) |
|
can you describe what you would do with the token? do you need a token or just a valid login to run osc commands with? would |
|
I need a token so I can pass it to docker login as the password Sent from my iPhone
|
|
Actually I can just do this in an integration test instead Sent from my iPhone
|
ncdc
force-pushed
the
auto-provision-image-repo
branch
from
a78df0c
to
91fda56
Compare
ncdc
changed the title
|
@smarterclayton PTAL. This is obviously v2 registry only. |
| if err := r.registryClient.ImageStreamMappings(r.namespace).Create(&irm); err != nil { | ||
| log.Errorf("Error creating ImageStreamMapping: %s", err) | ||
| return err | ||
| if err := r.registryClient.ImageStreamMappings(r.namespace).Create(&ism); err != nil { |
There was a problem hiding this comment.
nit: in the future you might want to make the if block return and the else be the rest of the page (with a good comment about autoprovision).
|
@smarterclayton any other comments or is it ok to merge when green? |
|
Merge when green |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1533/) (Image: devenv-fedora_1252) |
|
Evaluated for origin up to 91fda56 |
Merged by openshift-bot
…service-catalog/' changes from 3aacfedec6..aa27078754 aa27078754 origin build: add origin tooling bcf37fd 0.1.0-rc2 chart updates (openshift#1410) 4ab0a0a add back 'Processing' message for instance deletion (openshift#1332) 0ecbcb1 Update logs for Cluster service plans. (openshift#1389) 8b491ef Fix a quoting nit (openshift#1400) 63685e4 add orphan mitigation-specific conditions for instances (openshift#1378) adee662 Updated missed fields in service and plan specs (openshift#1406) 2095919 Handle default plan setting when using k8s names (openshift#1405) 607ba66 Document rbacEnable. (openshift#1404) 268294e Adding rbac definition for v1 api endpoint. (openshift#1284) 103288d differentiate between failed updates and provisions during deletion (openshift#1383) eba8ba4 enable API aggregation and Service Catalog RBAC on Jenkins (openshift#1333) 5a93315 Validate relistDuration is non-negative (openshift#1395) e279d21 Fix log messages for secrets (openshift#1385) 87fa8c9 fix status update when starting orphan mitigation (openshift#1372) 11f18f3 Switch to wget for integration apiserver checks (openshift#1384) 8c44a7d update OSB client to 2.13 (openshift#1392) e64bbd1 default plan admission controller: filter list of service plans/service classes by the class name (openshift#1351) 6648c0e Check field names. Fix issue 1291 (openshift#1379) 5319841 update comment for instance generation check (openshift#1382) 7d5823f remove internal poll method (openshift#1381) 07d3068 Rework the logging for controller_instance. (openshift#1371) 5f4ca01 address PR comment as a followup (openshift#1380) 485d5e6 Add support for specifying plan using K8S names. (openshift#1377) 662bba8 Log number of secret keys created for binding credential (openshift#1375) 8ad6a31 Move controller constants into correct files (openshift#1373) 7bd66dd Adding type to log. (openshift#1339) 1ce5c4d Remove k8s/k8s dependency (openshift#1355) b458323 Adding log formatting for BindingController. (openshift#1352) 275eb11 rename test variables to be consistent (openshift#1315) ffd6b8b travis: skip cleanup before deploy (openshift#1368) d5ecc04 fix travis tag checker (openshift#1365) 2cae0ee Minor updates to README (openshift#1360) REVERT: 3aacfedec6 carry: Set external plan name for service-catalog walkthrough REVERT: 3ec9e5b07a origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: aa2707875461dd51be3731b1d94b5cfc3b9a3976
* Document rbacEnable. * Fix format.
Auto provision an image stream when an image is pushed if the stream doesn't yet exist.